Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests: fix anomaly detection results forecast flaky test #186205

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Jun 13, 2024

Summary

Fixes skipped test due to flakiness: #164381
Moves the forecast checkbox uncheck to a separate test to ensure it doesn't happen before the forecast chart check passes.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6324

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing v8.15.0 labels Jun 13, 2024
@alvarezmelissa87 alvarezmelissa87 self-assigned this Jun 13, 2024
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner June 13, 2024 17:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 requested a review from qn895 June 13, 2024 17:43
Copy link
Member

@qn895 qn895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6324

[❌] x-pack/test/functional/apps/ml/anomaly_detection_result_views/config.ts: 0/40 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6323

[❌] x-pack/test/functional/apps/ml/anomaly_detection_result_views/config.ts: 0/40 tests passed.

see run history

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 13, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #48 / machine learning - anomaly detection forecasts with single metric job should allow interaction with the forecast
  • [job] [logs] FTR Configs #48 / machine learning - anomaly detection forecasts with single metric job should allow interaction with the forecast

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 deleted the ml-forecast-functional-test-fix branch July 8, 2024 19:14
@alvarezmelissa87
Copy link
Contributor Author

Closed in lieu of #187795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection Feature:Functional Testing :ml release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants