[Synthetics] Fix TLS cert view for > 3 monitors per cert #186204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpatticha
approved these changes
Jun 17, 2024
|
Thank you for the review @kpatticha. I have created #186391 to track the design concern, as for certain users this is definitely going to be an issue in the future. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 18, 2024
) ## Summary Resolves elastic#183985. This patch makes it so we can see more than three monitors per cert in the TLS page of Synthetics. I've set the default limit to the round number of 100. Realistically, users could have more than 100 monitors for the same cert, but also realistically, this page would need a layout overhaul to display that many monitors in a single row as well. ### Before <img width="1414" alt="image" src="https://github.com/elastic/kibana/assets/18429259/26357eee-b909-407a-af61-a61b5033e899"> ### After <img width="1412" alt="image" src="https://github.com/elastic/kibana/assets/18429259/51f47e4e-7b5b-4fa6-b20c-90344c0c6912"> ## Testing this PR Follow the simple repro instructions in the linked issue. On `main`, you should only see 3 or less monitors. On this branch, you should see all monitors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #183985.
This patch makes it so we can see more than three monitors per cert in the TLS page of Synthetics.
I've set the default limit to the round number of 100. Realistically, users could have more than 100 monitors for the same cert, but also realistically, this page would need a layout overhaul to display that many monitors in a single row as well.
Before
After
Testing this PR
Follow the simple repro instructions in the linked issue. On
main, you should only see 3 or less monitors. On this branch, you should see all monitors.