[APM] Correlations: Update field candidates request. #186182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
ml-apm-correlation-use-updated-field-caps-options
branch
from
a671ac1 to
b5b7911
Compare
walterra
added
release_note:skip
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @walterra |
MiriamAparicio
approved these changes
Jul 2, 2024
This was referenced Jul 2, 2024
walterra
added a commit
that referenced
this pull request
Jul 3, 2024
…187444) ## Summary Fixes #176544. Fixes #187421. Fixes #176119. Fixes #176425. Fixes #175855. Fixes #175911. Fixes #176780. Follow up to #186182. Reenables and stabilizes APM correlations API integration tests. Review hint: View with the `w=1` flag to ignore whitespace changes: https://github.com/elastic/kibana/pull/187444/files?w=1 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #178606.
Fixes #185875.
Since we created the correlations feature for APM, some new options were added to the
_field_capsAPI which allow us to improve the way we retrieve field candidates for the analysis.Previously we used 2 queries to get field candidates: We fetched all fields via
_field_caps, then searched for a random sample of 1000 docs to identify fields with values. Additional code would then filter the supported fields.Now we can use additional
_field_capsoptions to get rid of the random docs request and simplify some of the filtering code.filters: '-metadata,-parent'will exclude metadata and object fields,include_empty_fields: falsewill include populated fields only,index_filter: ...allows to provide a range filter withstart/endto limit the scope of indices,types: ...allows us to get only fields of the type supported by the analysis (keyword, boolean, ip).Checklist