Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [Roles] Support for remote_cluster field in ES role definition (#182377) #185919

Conversation

elena-shostak
Copy link
Contributor

Summary

Backported changes from

@elena-shostak elena-shostak requested a review from a team June 11, 2024 08:53
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elena-shostak
Copy link
Contributor Author

/ci

elena-shostak and others added 2 commits June 11, 2024 12:05
## Summary

Reordered sections in role management page. [As
agreed](elastic#182984 (comment))
the order is the following:

- Cluster
- Remote Cluster
- Run As
- Index
- Remote Index

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

__Fixes: https://github.com/elastic/kibana/issues/182984__
@elena-shostak elena-shostak force-pushed the backport/8.14/pr-182377_pr-184924 branch from 5eaca2a to 2a291dd Compare June 11, 2024 10:05
@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

ES doesn't support remote cluster in 8.14, there is no need to backport

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 11, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / it renders without crashing
  • [job] [logs] Jest Tests #12 / it renders without crashing
  • [job] [logs] FTR Configs #31 / security app dls "after all" hook: logout for "user East should only see EAST doc"
  • [job] [logs] FTR Configs #31 / security app dls "after all" hook: logout for "user East should only see EAST doc"
  • [job] [logs] FTR Configs #31 / security app dls should add new role myroleEast
  • [job] [logs] FTR Configs #31 / security app dls should add new role myroleEast

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
security 525 528 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/security-plugin-types-common 36 39 +3
security 199 203 +4
total +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 584.9KB 591.6KB +6.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 70.7KB 70.7KB +95.0B
Unknown metric groups

API count

id before after diff
@kbn/security-plugin-types-common 83 87 +4
security 409 415 +6
total +10

History

  • 💔 Build #215149 failed 5eaca2a7fe38dd84d70c778855a54a1c4f107445

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants