Adds SOM integration tests for serverless #184888

TinaHeiligers · 2024-06-06T02:31:07Z

Adds serverless api integration tests for Saved Objects Management

jloleysens · 2024-06-06T09:16:22Z

/ci

…fix'

...test_serverless/api_integration/test_suites/common/saved_objects_management/relationships.ts

@@ -81,244 +78,213 @@ export default function ({ getService }: FtrProviderContext) {
        );
        await kibanaServer.savedObjects.cleanStandardList();
      });
+      describe('searches', () => {


...test_serverless/api_integration/test_suites/common/saved_objects_management/relationships.ts

+            .set(svlCommonApi.getInternalRequestHeader())
+            .set(roleAuthc.apiKeyHeader)
+            .expect(200);
+          relations1 = body.relations[0];


TinaHeiligers · 2024-06-10T22:08:08Z

@TinaHeiligers Hello again madam! I'd like to humbly ask that you run this against MKI, perhaps using QAF?

As these will directly affect the following Monday's serverless, release, it'd be nice to know if they pass on MKI, as the configs that my team were pinged for in the PR, will be run on MKI

@wayneseymour they pass for an elasticsearch project: #184888 (comment).

I'm testing again for an observability and security project to be sure.

TinaHeiligers · 2024-06-10T22:11:03Z

@elasticmachine merge upstream

TinaHeiligers · 2024-06-10T23:59:08Z

@wayneseymour tests are ok for an o11y project too.

wayneseymour

I believe that if we can change supertest for supertestWithoutAuth where we are passing the internal request header and the api key header, this will be good to go.

Thanks Tina!

wayneseymour · 2024-06-11T08:22:56Z

...k/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_delete.ts

+export default function ({ getService }: FtrProviderContext) {
+  const svlCommonApi = getService('svlCommonApi');
+  const svlUserManager = getService('svlUserManager');
+  const supertest = getService('supertest');


I believe this should be supertestWithoutAuth, like this:
const supertestWithoutAuth = getService('supertestWithoutAuth');

wayneseymour · 2024-06-11T08:23:41Z

...k/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_delete.ts

+    }
+
+    it('should return 200 for an existing object', async () =>
+      await supertest


Should be await supertestWithoutAuth.
\cc @pheyos Please keep me honest here :)

Yes. supertest comes with operator privileges. When we use .set(roleAuthc.apiKeyHeader) to run with a proper role (like it's done here), we need to use supertestWithoutAuth instead.

wayneseymour · 2024-06-11T08:24:09Z

...k/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_delete.ts

+        }));
+
+    it('should return error for invalid object type', async () =>
+      await supertest


Same as above, should be await supertestWithoutAuth

wayneseymour · 2024-06-11T08:24:23Z

...k/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_delete.ts

+        }));
+
+    it('should return mix of successes and errors', async () =>
+      await supertest


Same as above, should be await supertestWithoutAuth

78cc092 (#184888)

wayneseymour · 2024-06-11T08:24:40Z

x-pack/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_get.ts

+export default function ({ getService }: FtrProviderContext) {
+  const svlCommonApi = getService('svlCommonApi');
+  const svlUserManager = getService('svlUserManager');
+  const supertest = getService('supertest');


Same as above, should be const supertestWithoutAuth = getService('supertestWithoutAuth');

wayneseymour · 2024-06-11T08:25:02Z

x-pack/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_get.ts

+      }
+
+      it('should return 200 for object that exists and inject metadata', async () =>
+        await supertest


Same as above, should be await supertestWithoutAuth

wayneseymour · 2024-06-11T08:25:07Z

x-pack/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_get.ts

+          }));
+
+      it('should return error for invalid object type', async () =>
+        await supertest


Same as above, should be await supertestWithoutAuth

wayneseymour · 2024-06-11T08:25:11Z

x-pack/test_serverless/api_integration/test_suites/common/saved_objects_management/bulk_get.ts

+          }));
+
+      it('should return mix of successes and errors', async () =>
+        await supertest


Same as above, should be await supertestWithoutAuth

TinaHeiligers · 2024-06-12T15:10:45Z

@elasticmachine merge upstream

TinaHeiligers · 2024-06-12T18:43:05Z

@elasticmachine merge upstream

TinaHeiligers · 2024-06-12T21:21:06Z

@elasticmachine merge upstream

kibana-ci · 2024-06-12T22:54:55Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 564884e
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-184888-564884e84ce8
Elasticsearch Serverless Deployment

Failed CI Steps

Jest Integration Tests #6

Test Failures

[job] [logs] Jest Integration Tests #6 / Migration actions - serverless environment readWithPit it excludes documents not matching the provided "query"
[job] [logs] Jest Integration Tests #6 / Migration actions - serverless environment readWithPit only returns documents that match the provided "query"
[job] [logs] Jest Integration Tests #6 / Migration actions - serverless environment readWithPit requests documents from an index using given PIT

Metrics [docs]

✅ unchanged

History

💛 Build #215567 was flaky 32ec76b
💔 Build #215531 failed 78cc092
💛 Build #215104 was flaky 6023dbf
💚 Build #215082 succeeded 395d1fe
💛 Build #214882 was flaky fcc9645
💛 Build #214818 was flaky cbc282b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers · 2024-06-13T01:51:38Z

@TinaHeiligers Hello again madam! I'd like to humbly ask that you run this against MKI, perhaps using QAF?

As these will directly affect the following Monday's serverless, release, it'd be nice to know if they pass on MKI, as the configs that my team were pinged for in the PR, will be run on MKI

@wayneseymour the tests against MKI (using QAF) passed!

wayneseymour

I just ran the oblt config against MKI, LGTM

TinaHeiligers and others added 9 commits June 3, 2024 09:11

Adds SOM integration tests for serverless

14428a9

Adds assertion for find

ba714a3

adds tests for bulk_get

2482892

adds tests for _bulk_delete

0eff45c

Adds scroll_count

601e55f

Adds scroll_count

907dc33

Merge branch 'main' into SOM-serverless-find-int-test

321db7b

Merge branch 'main' into SOM-serverless-find-int-test

ccb566c

Add relationships api integration tests

8032917

TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes test-api-integration Feature:Saved Objects Management v8.15.0 labels Jun 6, 2024

kibanamachine and others added 2 commits June 6, 2024 09:30

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

2446ef2

…fix'

Merge branch 'main' into kbn175757-serverless-SOM-APIint

a9cc309

This comment was marked as outdated.

Sign in to view

kibanamachine and others added 2 commits June 7, 2024 03:10

Merge branch 'main' into kbn175757-serverless-SOM-APIint

7de5703

Fix syntax

43afb95

This comment was marked as outdated.

Sign in to view

TinaHeiligers added 2 commits June 6, 2024 12:55

remove unused

b34e97c

Refactors relationships tests

8434dfd

TinaHeiligers mentioned this pull request Jun 7, 2024

Adds SOM integration tests for serverless #183970

Closed

This comment was marked as duplicate.

Sign in to view

Merge branch 'main' into kbn175757-serverless-SOM-APIint

4c58391

This comment was marked as duplicate.

Sign in to view

TinaHeiligers commented Jun 7, 2024

View reviewed changes

...test_serverless/api_integration/test_suites/common/saved_objects_management/relationships.ts Outdated

.set(svlCommonApi.getInternalRequestHeader())

.set(roleAuthc.apiKeyHeader)

.expect(200);

relations1 = body.relations[0];

This comment was marked as outdated.

Sign in to view

TinaHeiligers added ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project and removed ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project labels Jun 10, 2024

Merge branch 'main' into kbn175757-serverless-SOM-APIint

6023dbf

TinaHeiligers requested a review from wayneseymour June 10, 2024 23:06

wayneseymour requested changes Jun 11, 2024

View reviewed changes

TinaHeiligers removed ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project labels Jun 12, 2024

Merge branch 'main' into kbn175757-serverless-SOM-APIint

785504b

kibanamachine and others added 2 commits June 12, 2024 17:10

Merge branch 'main' into kbn175757-serverless-SOM-APIint

89214b9

use supertestWithoutAuth

78cc092

Merge branch 'main' into kbn175757-serverless-SOM-APIint

32ec76b

TinaHeiligers added ci:build-serverless-image ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project labels Jun 12, 2024

Merge branch 'main' into kbn175757-serverless-SOM-APIint

564884e

TinaHeiligers requested a review from wayneseymour June 13, 2024 01:51

delanni removed the ci:build-serverless-image label Jun 13, 2024

wayneseymour approved these changes Jun 13, 2024

View reviewed changes

TinaHeiligers merged commit c2a82fe into elastic:main Jun 13, 2024
9 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2024

TinaHeiligers deleted the kbn175757-serverless-SOM-APIint branch June 13, 2024 13:32

TinaHeiligers mentioned this pull request Jun 24, 2024

[core] Add SOM api integration tests for serverless #175757

Closed

Adds SOM integration tests for serverless #184888

Adds SOM integration tests for serverless #184888

Conversation

TinaHeiligers commented Jun 6, 2024

jloleysens commented Jun 6, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as outdated.

This comment was marked as outdated.

TinaHeiligers commented Jun 10, 2024 • edited Loading

TinaHeiligers commented Jun 10, 2024

TinaHeiligers commented Jun 10, 2024

wayneseymour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers commented Jun 12, 2024

TinaHeiligers commented Jun 12, 2024

TinaHeiligers commented Jun 12, 2024

kibana-ci commented Jun 12, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

TinaHeiligers commented Jun 13, 2024

wayneseymour left a comment

Choose a reason for hiding this comment

TinaHeiligers commented Jun 10, 2024 •

edited

Loading