-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code for redundant groupBy field in custom threshold and metric threshold rules #184787
Remove unused code for redundant groupBy field in custom threshold and metric threshold rules #184787
Conversation
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
buildkite test this |
@csyager Thanks for your contribution! :) Would you please fix the issue mentioned in the CI? You should be able to do so using the |
@elasticmachine merge upstream |
buildkite test this |
@maryam-saeidi I must be doing something wrong. The buildkite links are giving me "Page not found." I'm not finding anything in the contributor docs about it, any idea what I'm missing? |
@csyager Maybe it is due to not having permission, here is the error: Committing the result of the |
buildkite test this |
1 similar comment
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in the review. I've tested the PR locally, and it worked as expected. ✨
I saw in the PR that this change was introduced, an errorOptions prop was added to the MetricsExplorerGroupBy
component, any reason for not removing that prop too?
If there is no usage for it in the code, would you please remove that prop both from MetricsExplorerGroupBy
component for metric threshold and GroupBy
component for the custom threshold rule? Thanks!
Not a problem, thanks for taking a look. I thought about removing that too, I'll go ahead and do that and put a new commit in. |
@elasticmachine merge upstream |
merge conflict between base and head |
d916f06
to
991fc6e
Compare
buildkite test this |
buildkite test this |
buildkite test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested locally, and filter and group were saved as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
buildkite test this |
⏳ Build in-progress
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
buildkite test this |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
|
Summary
Closes #184712
Previously, when a user tries to create an alert with a
groupBy
with a field that is already filtered down to just one match by the KQL query, the UI would warn them that the filter query already contains an exact match. However, this is not desirable behavior, as adding "redundant" groupBy fields can be used to trigger alerts for data storage scenarios. Regardless, this warning is not currently being enforced by the UI and the warning was never enforced by the API, so this change removes the logic.Change that had initially implemented this logic: #111891
This screenshot shows an example alert configuration that would previously have gotten a warning:
Checklist
Delete any items that are not applicable to this PR.
For maintainers