-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Improve user messagging #184233
Merged
markov00
merged 13 commits into
elastic:main
from
markov00:2024_05_21-improve_user_messagging
Jun 5, 2024
Merged
[Lens] Improve user messagging #184233
markov00
merged 13 commits into
elastic:main
from
markov00:2024_05_21-improve_user_messagging
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
commented
May 27, 2024
x-pack/plugins/lens/public/datasources/form_based/operations/definitions/calculations/utils.ts
Show resolved
Hide resolved
markov00
commented
May 27, 2024
markov00
added
technical debt
Improvement of the software architecture and operational architecture
release_note:skip
Skip the PR/issue when compiling release notes
labels
May 28, 2024
dej611
reviewed
Jun 4, 2024
x-pack/plugins/lens/public/datasources/form_based/operations/definitions/formula/validation.ts
Outdated
Show resolved
Hide resolved
...ugins/lens/public/datasources/form_based/operations/definitions/formula/validation_errors.ts
Outdated
Show resolved
Hide resolved
...ugins/lens/public/datasources/form_based/operations/definitions/formula/validation_errors.ts
Outdated
Show resolved
Hide resolved
...ugins/lens/public/datasources/form_based/operations/definitions/formula/validation_errors.ts
Show resolved
Hide resolved
dej611
added
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Feature:Lens
labels
Jun 5, 2024
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
technical debt
Improvement of the software architecture and operational architecture
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleaned up a bit our user messages. In particular:
uniqueId
for aUserMessage
making it uniquely identifiable across various message renderers (moves toward this objective: [Lens] hide missing fields errors until the data view has some fields #151526)Subsequent possible steps, outside this PR:
UserMessage
,FieldBasedOperationErrorMessage
andValidationErrors
uniqueId
to guide future developments