-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Rules] Fix flaky rule details page tests #183888
[ResponseOps][Rules] Fix flaky rule details page tests #183888
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6053[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 26/50 tests passed. |
ff2d1fe
to
c70589e
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6073[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 50/50 tests passed. |
c70589e
to
135f62b
Compare
Pinging @elastic/response-ops (Team:ResponseOps) |
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6078[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 175/200 tests passed. |
This refers to a previous commit. This is the correct one |
@umbopepato If you go to the run history you can see that the flaky test runner ran on the latest commit. Nevertheless, the error does not seem to be related to the tests you unskipped so it is safe to merge! |
Summary
Prevents the rule details page's lazyly loaded components from re-triggering the fallback state of the top-level
<Suspense>
that was causing a Flash of Content, the likely cause of #172941 and #173008.Details
Slowed down screen capture of the loading flash
Rule.detail.page.loading.issue.mp4
My guess is that in the flaky test runs the
Edit
button was pressed just before the component was temporarily removed from the render tree and therefore the flyout couldn't render correctly.To verify
Stack Management
Stack Management
>Rules
> Click on rule in list)Fixes #172941
Fixes #173008