Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Rules] Fix flaky rule details page tests #183888

Merged
merged 1 commit into from
May 24, 2024

Conversation

umbopepato
Copy link
Member

@umbopepato umbopepato commented May 21, 2024

Summary

Prevents the rule details page's lazyly loaded components from re-triggering the fallback state of the top-level <Suspense> that was causing a Flash of Content, the likely cause of #172941 and #173008.

Details

Slowed down screen capture of the loading flash
Rule.detail.page.loading.issue.mp4

My guess is that in the flaky test runs the Edit button was pressed just before the component was temporarily removed from the render tree and therefore the flyout couldn't render correctly.

To verify

  1. Create any type of rule from Stack Management
  2. Navigate to that rule's detail page (Stack Management > Rules > Click on rule in list)
  3. Verify that the page header only loads once without going back to the loading indicator (throttling the network from the DevTools or capturing the screen and playing back the video slowed down might help).

Fixes #172941
Fixes #173008

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6053

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 26/50 tests passed.

see run history

@umbopepato umbopepato force-pushed the 172941-rule-details-flaky-test branch from ff2d1fe to c70589e Compare May 22, 2024 16:02
@umbopepato umbopepato changed the title [ResponseOps][Rules] Fix flaky rule details page test [ResponseOps][Rules] Fix flaky rule details page tests May 22, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6073

[✅] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 50/50 tests passed.

see run history

@umbopepato umbopepato added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes labels May 22, 2024
@umbopepato umbopepato force-pushed the 172941-rule-details-flaky-test branch from c70589e to 135f62b Compare May 22, 2024 17:17
@umbopepato umbopepato marked this pull request as ready for review May 22, 2024 17:28
@umbopepato umbopepato requested a review from a team as a code owner May 22, 2024 17:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@umbopepato
Copy link
Member Author

/ci

@umbopepato umbopepato requested review from adcoelho and JiaweiWu May 22, 2024 17:29
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +61.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6078

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 175/200 tests passed.

see run history

@umbopepato
Copy link
Member Author

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6078

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 175/200 tests passed.

see run history

This refers to a previous commit. This is the correct one

@cnasikas
Copy link
Member

cnasikas commented May 24, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6078

[❌] x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/config.ts: 175/200 tests passed.
see run history

This refers to a previous commit. This is the correct one

@umbopepato If you go to the run history you can see that the flaky test runner ran on the latest commit.

Screenshot 2024-05-24 at 2 08 46 PM

Nevertheless, the error does not seem to be related to the tests you unskipped so it is safe to merge!

@umbopepato umbopepato merged commit e7e0c86 into elastic:main May 24, 2024
19 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment