Displays a y axis max value based on the data displayed in the chart #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splayed in the chart
|
Would like to see tests for this fix |
|
Yes, thats why I didn't add the review label. I need to write tests for this. |
|
Hi there, Just to be sure, will that fixe this type of visualization (beta 2) ? :
Thx. |
|
@ZeAleks no, this pull request won't change your visualization. What you want is for the charts to not share the same y axis scale. I will create an issue around what you are asking for. But essentially you want the y-axis in each chart to fit the bounds of the data. For reference, this issue is #2021. |
|
LGTM, merging. |
rashidkpc
added a commit
that referenced
this pull request
Nov 25, 2014
Displays a y axis max value based on the data displayed in the chart
|
What is the status of this feature now? Is it included in any release yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1821.
The problem is that the y max value for the y axis is based on the max value of all the data returned in an elasticsearch response. Elasticsearch may return buckets that fall outside of the time range specified (for more see my comments in #1787). In Kibana, however, we respect the time range the user selects and will only show data within that time range. Therefore, if the bucket that falls outside of the time range has the highest y value, then the y axis will use that value to set the max y axis value rather than taking the max value of the buckets displayed in the chart.
This pull request fixes this issue by pulling the y max value from the buckets displayed within the chart.