Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] AIOps: Get data view via context instead of prop drilling. #181797

Merged
merged 1 commit into from
Apr 26, 2024
Merged

[ML] AIOps: Get data view via context instead of prop drilling. #181797

merged 1 commit into from
Apr 26, 2024

Conversation

walterra
Copy link
Contributor

Summary

Part of #181603.

In the aiops plugin the data view is available via DataSourceContext. This PR removes the data view being passed around via components props and uses useDataSource instead.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.15.0 labels Apr 26, 2024
@walterra walterra self-assigned this Apr 26, 2024
@walterra walterra requested a review from a team as a code owner April 26, 2024 06:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Apr 26, 2024
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 414.3KB 414.4KB +40.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

jgowdyelastic
jgowdyelastic approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@walterra walterra merged commit 9ea394b into elastic:main Apr 26, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2024
@walterra walterra deleted the ml-aiops-data-view-via-context branch April 26, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @alvarezmelissa87 @jgowdyelastic @kibanamachine