Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][Osquery][E2E] Unskip osquery packs_integration·cy·ts test #180457

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Apr 10, 2024

closes #180424

The SuperSelect EUI component started showing an extra <span/> when it displayed the selected value (change from elastic/eui#7650) . This caused a problem in a test that checks the agent policy name strictly. I changed the test to see if the text contains the string instead of has it. I checked the flow and found it doesn't affect the data sent to the API. Also, the euiScreenReaderOnly property hides this extra span in the regular UI so it is not visible to users.

Screenshot 2024-04-10 at 12 47 31

@szwarckonrad szwarckonrad self-assigned this Apr 10, 2024
@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0 labels Apr 10, 2024
@szwarckonrad szwarckonrad changed the title Unskip osquery packs_integration·cy·ts test [EDR Workflows][Osquery][E2E] Unskip osquery packs_integration·cy·ts test Apr 10, 2024
@szwarckonrad szwarckonrad marked this pull request as ready for review April 10, 2024 11:09
@szwarckonrad szwarckonrad requested a review from a team as a code owner April 10, 2024 11:09
@szwarckonrad szwarckonrad enabled auto-merge (squash) April 10, 2024 11:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@tomsonpl tomsonpl disabled auto-merge April 10, 2024 12:30
@tomsonpl
Copy link
Contributor

/ci

@szwarckonrad szwarckonrad enabled auto-merge (squash) April 11, 2024 07:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit 13c3da1 into elastic:main Apr 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0
Projects
None yet
4 participants