Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons must have discernible text issue by adding aria-label #179892

Merged

Conversation

maryam-saeidi
Copy link
Member

Fixes #179490

Summary

This PR fixes buttons must have discernible text issues by adding aria-label to the EuiButtonEmpty components.

@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team labels Apr 3, 2024
@maryam-saeidi maryam-saeidi self-assigned this Apr 3, 2024
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner April 3, 2024 08:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / unified data table should update row Height correctly
  • [job] [logs] Jest Tests #12 / unified timeline unified field list should remove the column when clicked on X sign

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 263.5KB 263.6KB +66.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi merged commit 0a3a8bb into elastic:main Apr 3, 2024
28 checks passed
@maryam-saeidi maryam-saeidi deleted the 179490-fix-accessibility-issue branch April 3, 2024 10:15
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.14.0
Projects
None yet
6 participants