Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] client-side validation: make and and or accept null #179707

Merged
merged 3 commits into from
Apr 2, 2024
Merged

[ES|QL] client-side validation: make and and or accept null #179707

merged 3 commits into from
Apr 2, 2024

Conversation

drewdaemon
Copy link
Contributor

Summary

Part of #177699

AND and OR were not accepting NULL as an argument when they should have.

The most basic test case is

ROW var = TRUE or NULL.

Checklist

@drewdaemon drewdaemon added release_note:fix Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Mar 29, 2024
@drewdaemon drewdaemon mentioned this pull request Mar 29, 2024
Open
5 tasks
@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon marked this pull request as ready for review March 29, 2024 20:24
@drewdaemon drewdaemon requested a review from a team as a code owner March 29, 2024 20:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

/ci

stratoula
stratoula approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanx Drew! LGTM!

@drewdaemon drewdaemon enabled auto-merge (squash) April 2, 2024 17:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.9MB 2.9MB +261.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 97e554c into elastic:main Apr 2, 2024
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 left review comments

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:fix Team:ESQL ES|QL related features in Kibana v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drewdaemon @elasticmachine @stratoula @kibana-ci @dej611 @kibanamachine