Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability Onboarding] Link all “Add data” buttons in observability to onboarding landing page #179459

Merged
merged 2 commits into from
Mar 27, 2024
Merged

[Observability Onboarding] Link all “Add data” buttons in observability to onboarding landing page #179459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bd22d7
Update add data links in infra plugin
thomheymann Mar 26, 2024
34bc85d
Fix selection bug caused by too generic ids
thomheymann Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions x-pack/plugins/observability_solution/infra/public/pages/logs/page_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const LogsPageContent: React.FunctionComponent = () => {
</EuiHeaderLink>
<LazyAlertDropdownWrapper />
<EuiHeaderLink
href={getUrlForApp('/integrations/browse')}
href={getUrlForApp('/observabilityOnboarding')}
color="primary"
iconType="indexOpen"
>
Expand All @@ -104,7 +104,15 @@ export const LogsPageContent: React.FunctionComponent = () => {
<RedirectWithQueryParams from={'/analysis'} to={anomaliesTab.pathname} exact />
<RedirectWithQueryParams from={'/log-rate'} to={anomaliesTab.pathname} exact />
<RedirectWithQueryParams from={'/'} to={streamTab.pathname} exact />
<Route render={() => <NotFoundPage title="Logs" />} />
<Route
render={() => (
<NotFoundPage
title={i18n.translate('xpack.infra.logs.index.logsLabel', {
defaultMessage: 'Logs',
})}
/>
)}
/>
</Routes>
</>
);
Expand Down
14 changes: 12 additions & 2 deletions x-pack/plugins/observability_solution/infra/public/pages/metrics/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ export const InfrastructurePage = () => {
<MetricsAlertDropdown />
)}
<EuiHeaderLink
href={kibana.services?.application?.getUrlForApp('/integrations/browse')}
href={kibana.services?.application?.getUrlForApp(
'/observabilityOnboarding'
)}
color="primary"
iconType="indexOpen"
>
Expand Down Expand Up @@ -144,7 +146,15 @@ export const InfrastructurePage = () => {
<RedirectWithQueryParams from="/metrics-explorer" exact to="/explorer" />
<RedirectWithQueryParams from="/" exact to="/inventory" />

<Route render={() => <NotFoundPage title="Infrastructure" />} />
<Route
render={() => (
<NotFoundPage
title={i18n.translate('xpack.infra.header.infrastructureLabel', {
defaultMessage: 'Infrastructure',
})}
/>
)}
/>
</Routes>
</InfraMLCapabilitiesProvider>
</AlertPrefillProvider>
Expand Down
5 changes: 4 additions & 1 deletion ...observability_onboarding/public/application/onboarding_flow_form/onboarding_flow_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
EuiFlexGrid,
EuiAvatar,
useEuiTheme,
useGeneratedHtmlId,
} from '@elastic/eui';

interface UseCaseOption {
Expand Down Expand Up @@ -159,6 +160,7 @@ export const OnboardingFlowForm: FunctionComponent = () => {
},
];

const radioGroupId = useGeneratedHtmlId({ prefix: 'onboardingUseCase' });
const [selectedId, setSelectedId] = useState<string>();
const [hoveredId, setHoveredId] = useState<string>();

Expand Down Expand Up @@ -194,7 +196,8 @@ export const OnboardingFlowForm: FunctionComponent = () => {
{/* Using EuiSpacer instead of EuiFlexGroup to ensure spacing is part of hit area for mouse hover effect */}
{index > 0 && <EuiSpacer size="m" />}
<EuiCheckableCard
id={option.id}
id={`${radioGroupId}_${option.id}`}
name={radioGroupId}
label={option.label}
checked={selectedId === option.id}
onChange={() => setSelectedId(option.id)}
Expand Down