Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting/storage] set refresh=wait_for in indexing and update calls #178783

Merged
merged 3 commits into from
Mar 18, 2024
Merged

[Reporting/storage] set refresh=wait_for in indexing and update calls #178783

merged 3 commits into from
Mar 18, 2024

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Mar 14, 2024 •
edited
Loading

Summary

Addresses #176022 (comment)

This is done in a standalone PR to minimize changes needed to convert Reporting storage to use a Data Stream. Useful for #176022.

@tsullivan tsullivan marked this pull request as ready for review March 14, 2024 23:29
@tsullivan tsullivan requested a review from a team as a code owner March 14, 2024 23:29
@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Mar 14, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / Actions and Triggers app Global alerts page Loads the page with actions but not alerting privilege Loads the page but shows missing permission prompt

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rshen91
rshen91 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@tsullivan tsullivan merged commit aceeb88 into elastic:main Mar 18, 2024
18 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 18, 2024
@tsullivan tsullivan deleted the reporting/storage-add-refresh-wait-for branch March 18, 2024 20:13
saikatsarkar056 pushed a commit to saikatsarkar056/kibana that referenced this pull request Mar 21, 2024
@tsullivan @saikatsarkar056
[Reporting/storage] set refresh=wait_for in indexing and update calls (…
3608e4d 
…elastic#178783)

## Summary

Addresses
elastic#176022 (comment)

This is done in a standalone PR to minimize changes needed to convert
Reporting storage to use a Data Stream. Useful for
elastic#176022.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshen91 rshen91 rshen91 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsullivan @kibana-ci @rshen91 @kibanamachine