Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AIOps: Use field caps option include_empty_fields=false instead of custom query. #178699

Merged

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 14, 2024

Summary

Part of #178606.

As of elastic/elasticsearch#103651 there is a new field caps option include_empty_fields. This PR updates AIOps Log Rate Analysis to make use of this option instead of a custom query and code that identified populated fields.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.14.0 labels Mar 14, 2024
@walterra walterra self-assigned this Mar 14, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra marked this pull request as ready for review March 14, 2024 15:36
@walterra walterra requested a review from a team as a code owner March 14, 2024 15:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra requested review from darnautov and qn895 March 14, 2024 15:37
@qn895
Copy link
Member

qn895 commented Mar 14, 2024

Code LGTM 🎉

Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit 7b1af2a into elastic:main Mar 14, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 14, 2024
@walterra walterra deleted the 178606-ml-aiops-field-caps-exclude-empty-fields branch March 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants