-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New slo plugin #177937
Merged
Merged
New slo plugin #177937
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
220d7f6
create new slos plugin
mgiota af1dea4
include new slos plugin in more places
mgiota 199bc18
add SLOs to the sidebar
mgiota 821e629
rename plugin to slo
mgiota 6d16bca
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota 905cf5a
move slo stuff from observability to slo plugin
mgiota dc12fda
update references
mgiota da7435d
update more references mainly on public folder
mgiota 41fc81c
more updates
mgiota 634b68d
successfully render first slo pages
mgiota 925f9fd
use typed kibana and fix translations
mgiota 904753c
fix errors and translations
mgiota 8f2a373
register burn rate rule type and embeddable alerts table configuration
mgiota 20a2995
clean up
mgiota 8ab35be
handle redirects of old paths to new app
mgiota 2e127f0
fix failing tests
mgiota b90e02a
fix translations
mgiota 9398707
update translation files
mgiota 8446fe0
fix more translations
mgiota 7b21743
Add application usage
mgiota 36a5df0
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota d0c6e32
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota 20897ca
Merge branch 'main' into new_slo_plugin
kibanamachine 3327ac4
fix eslint issues
mgiota 037f384
use old ALERTS_TABLE_ID
mgiota ddcfa98
fix create slo in logs explorer & more fixes
mgiota 53e8442
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 1e941f5
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
kibanamachine ead9ecf
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine 02e383a
copy render cell value
shahzad31 05b7084
move alert components
shahzad31 ca8a7d6
Merge branch 'main' of https://github.com/elastic/kibana into new_slo…
shahzad31 9f97061
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine c87039a
commit limits
shahzad31 91b9b64
Merge branch 'new_slo_plugin' of https://github.com/mgiota/kibana int…
shahzad31 6ad6dad
fix types
shahzad31 93a7ab8
types check
shahzad31 28633b4
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 0f54fa7
is dev flag
shahzad31 7ab440a
constatns
shahzad31 b404ad3
Merge branch 'new_slo_plugin' of https://github.com/mgiota/kibana int…
shahzad31 2d0e9ef
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine bc61ba2
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota 0dd62ce
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 3aeaa85
bring back DatePicker, it is used by ux plugin, rum dashboard
mgiota e62e11c
revert alert table changes
mgiota ef76378
move slo embeddable alert table configuration to observability plugin
mgiota 2a2fc5b
fix aiassistant type issues
mgiota e8caaf2
Merge branch 'main' into new_slo_plugin
kibanamachine 7f527ca
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine fd023d5
delete render_cell_value
mgiota 7357191
remove use_get_alert_flyout_components export
mgiota 60f3844
update application usage keys in the schema to match the registered a…
mgiota 0cbb0af
fix linter issues
mgiota 5c5738d
update telemetry schema
mgiota f4a7dac
fix imports in tests
mgiota df2314b
fix CI
mgiota 7f44706
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota c4471b5
more fixes
mgiota e332ee0
fix eslint issues
mgiota 3a12e97
Merge branch 'main' into new_slo_plugin
kibanamachine 31fe2f6
remove ObservabilityAIAssistantActionMenuItem from SLO header menu
mgiota 25147a7
fix types
mgiota 5145e70
Merge branch 'main' into new_slo_plugin
kibanamachine 250ffe4
Merge branch 'main' into new_slo_plugin
kibanamachine 5ad3345
Merge branch 'main' into new_slo_plugin
kibanamachine 7573311
enable slo plugin on serverless
mgiota 161e11b
Fix for redirection
CoenWarmer f83a337
Merge branch 'new_slo_plugin' of https://github.com/mgiota/kibana int…
CoenWarmer f72fa02
oops bring back observability on serverless
mgiota efb6a87
add SLOs link in the serverless navigation
mgiota 50c94c5
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota 9f7aaff
fix deep link id for slos
mgiota 6688ad5
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota 70118a8
keep same order for alerts slos cases in the navigation
mgiota 6ddf511
Merge branch 'main' into new_slo_plugin
kibanamachine 0f02d22
handle redirects for slo detail and edit pages
mgiota 4f5638c
Merge branch 'main' into new_slo_plugin
kibanamachine 2e57cfa
Merge branch 'main' into new_slo_plugin
kibanamachine 49d838b
Merge branch 'main' into new_slo_plugin
kibanamachine 5425dbd
fix failing tests
mgiota b6bfce4
update global nav
mgiota b992500
Merge branch 'main' into new_slo_plugin
kibanamachine a561a6f
show slo link when right capabilities
mgiota cbabcd5
slos is not a deep link anymore, remove from these tests
mgiota c401dff
Merge branch 'main' of github.com:elastic/kibana into new_slo_plugin
mgiota File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"General" is too vague, one doesn't know if it's an average, weighted average, or something else.
The same comment holds for the other descriptions using the term "General"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TinaHeiligers Thanks I updated the descriptions accordingly, replacing
General
withTotal
as per your suggestionSince these descriptions were generated after I ran
node scripts/telemetry_check --fix
, I updated the default description in the common schema.Btw do you know where I can check in Kibana the generated telemetry? Here's how I used to do it in the past, but it doesn't work this way now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, that's news to me. What doesn't work? Is the button missing, are your fields not there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything about
Usage Data
under Advanced Settings. How can I test the telemetry that will be sent while I navigate to the SLO app?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw after me applying the change regarding Renaming
General
toTotal
CI complains and wants me to update all descriptions. I did the change in this commit (not manual, I simply rannode scripts/telemetry_check --fix
). Is it fine or do you want me to revert back toGeneral
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Usage collection section moved to the "Global Settings" tab in Advanced Settings:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! That's what I was searching for, thanks!
Regarding my question here, is it fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About those descriptions: It looks like other applications also use the "General" term. Maybe it's best to keep them as you had.
Up to you thought, these are for internal use.
Telemetry related changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I kept them as before. Thanks!