[Observability Solution][Maintenance] Move to Emotion CSS, enable Telemetry and i18n ESLint rules for all Obs plugins #177785
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ export const SearchControls = ({ search, onSearch, onSort, isLoading }: SearchCo | |
| <EuiFlexGroup gutterSize="xs" responsive={false}> | ||
| <EuiFlexItem> | ||
| <EuiFieldSearch | ||
| data-test-subj="logsExplorerSearchControlsFieldSearch" | ||
| compressed | ||
| incremental | ||
| value={search.name} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ export function HighlightSection({ title, children, columns, ...props }: Highlig | |
| const showMoreButtonLabel = flyoutAccordionShowMoreText(hiddenCount); | ||
| const showMoreButton = ( | ||
| <EuiButtonEmpty | ||
| data-test-subj="logsExplorerHighlightSectionButton" | ||
CoenWarmer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| size="xs" | ||
| flush="left" | ||
| css={{ width: '80px' }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,7 @@ export const HoverActionPopover = ({ | |
| {hoverActions.map((action) => ( | ||
| <EuiToolTip content={action.tooltipContent} key={action.id}> | ||
| <EuiButtonIcon | ||
| data-test-subj="logsExplorerHoverActionPopoverButton" | ||
| size="xs" | ||
| iconType={action.iconType} | ||
| aria-label={action.tooltipContent as string} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,9 @@ | |
| */ | ||
|
|
||
| import React, { useMemo } from 'react'; | ||
| import { css } from '@emotion/css'; | ||
| import { EuiButtonIcon, EuiText } from '@elastic/eui'; | ||
| import { euiThemeVars } from '@kbn/ui-theme'; | ||
| import type { DataGridCellValueElementProps } from '@kbn/unified-data-table'; | ||
| import { getShouldShowFieldHandler } from '@kbn/discover-utils'; | ||
| import { i18n } from '@kbn/i18n'; | ||
|
|
@@ -16,7 +18,6 @@ import { useDocDetail, getMessageWithFallbacks } from '../../hooks/use_doc_detai | |
| import { LogDocument } from '../../../common/document'; | ||
| import { LogLevel } from '../common/log_level'; | ||
| import * as constants from '../../../common/constants'; | ||
|
|
||
| const SourceDocument = dynamic( | ||
| () => import('@kbn/unified-data-table/src/components/source_document') | ||
|
|
@@ -26,6 +27,11 @@ const DiscoverSourcePopoverContent = dynamic( | |
| () => import('@kbn/unified-data-table/src/components/source_popover_content') | ||
| ); | ||
|
|
||
| const sourceDocumentClassName = css` | ||
| display: inline !important; | ||
| margin-left: ${euiThemeVars.euiSizeXS}; | ||
| `; | ||
|
|
||
| const LogMessage = ({ field, value }: { field?: string; value: string }) => { | ||
| const renderFieldPrefix = field && field !== constants.MESSAGE_FIELD; | ||
| return ( | ||
|
|
@@ -115,7 +121,7 @@ export const Content = ({ | |
| shouldShowFieldHandler={shouldShowFieldHandler} | ||
| maxEntries={50} | ||
| dataTestSubj="logsExplorerCellDescriptionList" | ||
| className={sourceDocumentClassName} | ||
| /> | ||
| )} | ||
| </span> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,17 +15,22 @@ import { | |
| EuiText, | ||
| EuiTitle, | ||
| } from '@elastic/eui'; | ||
| import { css } from '@emotion/css'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import { truncate } from 'lodash'; | ||
| import React, { useContext } from 'react'; | ||
| import { ThemeContext } from 'styled-components'; | ||
| import { NewsItem as INewsItem } from './helpers/get_news_feed'; | ||
|
|
||
| interface Props { | ||
| items: INewsItem[]; | ||
| } | ||
|
|
||
| const imageClassName = css` | ||
| box-shadow: 0 0.7px 1.4px rgba(0, 0, 0, 0.07), 0 1.9px 4px rgba(0, 0, 0, 0.05), | ||
| 0 4.5px 10px rgba(0, 0, 0, 0.05); | ||
| `; | ||
|
|
||
| export function NewsFeed({ items }: Props) { | ||
| return ( | ||
| // The news feed is manually added/edited, to prevent any errors caused by typos or missing fields, | ||
|
|
@@ -98,7 +103,7 @@ function NewsItem({ item }: { item: INewsItem }) { | |
| height={48} | ||
| alt={item.title.en} | ||
| src={item.image_url.en} | ||
| className={imageClassName} | ||
| /> | ||
| </EuiFlexItem> | ||
| )} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -110,7 +110,12 @@ export const AlertsPopover = () => { | |
| {state.isAddRuleFlyoutOpen && addRuleFlyout} | ||
| <EuiPopover | ||
| button={ | ||
| <EuiButtonEmpty | ||
| data-test-subj="observabilityLogsExplorerAlertsPopoverAlertsButton" | ||
|
There was a problem hiding this comment. The Telemetry ESLint rule is configured to autofix, so the CI has added these. |
||
| onClick={togglePopover} | ||
| iconType="arrowDown" | ||
| iconSide="right" | ||
| > | ||
| <FormattedMessage | ||
| id="xpack.observabilityLogsExplorer.alertsPopover.buttonLabel" | ||
| defaultMessage="Alerts" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundle was going 1.2kb over the limit