[Cases] Unskip flyout and custom fields flaky tests #177590
Conversation
cnasikas
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
| expect(getByTestId('create-case-flyout')).toBeTruthy(); | ||
| }); | ||
| appMockRenderer.render(<CreateCaseFlyout {...defaultProps} />); | ||
| await waitForComponentToUpdate(); |
There was a problem hiding this comment.
Added this to eliminate the Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function. warning.
| jest.clearAllMocks(); | ||
| appMockRenderer = createAppMockRenderer(); |
There was a problem hiding this comment.
Not specific reason, probably a random copy-paste from another test. Do you want me to change the order?
There was a problem hiding this comment.
No no, I was just wondering if you had found some little performance hack that said moving these to the beforeEach block was more efficient 😄
You can leave as is 👍
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @cnasikas |
## Summary PR elastic#176863 improved the cases context provided which we assumed caused some flakiness in our tests. I am unskipping a couple of tests to test if the changes on that PR stabilized the tests. Fixes elastic#176805 Fixes elastic#174528 Fixes elastic#174527 Fixes elastic#174526 Fixes elastic#174525 Fixes elastic#176600 Fixes elastic#146394 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Summary
PR #176863 improved the cases context provided which we assumed caused some flakiness in our tests. I am unskipping a couple of tests to test if the changes on that PR stabilized the tests.
Fixes #176805
Fixes #174528
Fixes #174527
Fixes #174526
Fixes #174525
Fixes #176600
Fixes #146394
Checklist
Delete any items that are not applicable to this PR.
For maintainers