[Security Solution] Enable per field diffs feature #177495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
17 tasks
banderror
requested review from
a team,
jpdjere and
dplumlee
and removed request for
jpdjere
banderror
force-pushed
the
per-field-diffs-enabled-by-default
branch
2 times, most recently
from
5662dea to
a75c77c
Compare
dplumlee
approved these changes
Feb 22, 2024
banderror
force-pushed
the
per-field-diffs-enabled-by-default
branch
from
a75c77c to
634caac
Compare
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: cc @banderror |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
banderror
added a commit
to banderror/kibana
that referenced
this pull request
Feb 23, 2024
**Addresses:** elastic#166489 ## Summary Turns on the `perFieldPrebuiltRulesDiffingEnabled` feature flag by default. This will enable the `Updates` tab containing per-field rule diffs in the rule upgrade flyout. The feature will be enabled in `8.13.0` and Serverless. See more info in the related ticket. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 61b7f67) # Conflicts: # x-pack/plugins/security_solution/common/experimental_features.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
@dplumlee Could you please approve the manually created backport and update the ticket? |
banderror
added a commit
that referenced
this pull request
Feb 23, 2024
…177708) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] Enable per field diffs feature (#177495)](#177495) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Georgii Gorbachev","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-23T12:28:22Z","message":"[Security Solution] Enable per field diffs feature (#177495)\n\n**Addresses:** https://github.com/elastic/kibana/issues/166489\r\n\r\n## Summary\r\n\r\nTurns on the `perFieldPrebuiltRulesDiffingEnabled` feature flag by\r\ndefault.\r\n\r\nThis will enable the `Updates` tab containing per-field rule diffs in\r\nthe rule upgrade flyout. The feature will be enabled in `8.13.0` and\r\nServerless. See more info in the related ticket.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"61b7f67bda066d57455f5ca2ed69fd4e61657ffb","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","ci:cloud-deploy","ci:project-deploy-security","v8.13.0","v8.14.0"],"number":177495,"url":"https://github.com/elastic/kibana/pull/177495","mergeCommit":{"message":"[Security Solution] Enable per field diffs feature (#177495)\n\n**Addresses:** https://github.com/elastic/kibana/issues/166489\r\n\r\n## Summary\r\n\r\nTurns on the `perFieldPrebuiltRulesDiffingEnabled` feature flag by\r\ndefault.\r\n\r\nThis will enable the `Updates` tab containing per-field rule diffs in\r\nthe rule upgrade flyout. The feature will be enabled in `8.13.0` and\r\nServerless. See more info in the related ticket.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"61b7f67bda066d57455f5ca2ed69fd4e61657ffb"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177495","number":177495,"mergeCommit":{"message":"[Security Solution] Enable per field diffs feature (#177495)\n\n**Addresses:** https://github.com/elastic/kibana/issues/166489\r\n\r\n## Summary\r\n\r\nTurns on the `perFieldPrebuiltRulesDiffingEnabled` feature flag by\r\ndefault.\r\n\r\nThis will enable the `Updates` tab containing per-field rule diffs in\r\nthe rule upgrade flyout. The feature will be enabled in `8.13.0` and\r\nServerless. See more info in the related ticket.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"61b7f67bda066d57455f5ca2ed69fd4e61657ffb"}}]}] BACKPORT-->
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
**Addresses:** elastic#166489 ## Summary Turns on the `perFieldPrebuiltRulesDiffingEnabled` feature flag by default. This will enable the `Updates` tab containing per-field rule diffs in the rule upgrade flyout. The feature will be enabled in `8.13.0` and Serverless. See more info in the related ticket. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #166489
Summary
Turns on the
perFieldPrebuiltRulesDiffingEnabledfeature flag by default.This will enable the
Updatestab containing per-field rule diffs in the rule upgrade flyout. The feature will be enabled in8.13.0and Serverless. See more info in the related ticket.Checklist