Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moving] Move APM and APM_Data_Access folders into /x-pack/observability_solution/ #177433

Merged
merged 20 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8b0ccd3
Move plugin folder
CoenWarmer Feb 21, 2024
410606b
Update references
CoenWarmer Feb 21, 2024
7035519
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 22, 2024
8c7f218
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 22, 2024
451d685
Merge branch 'main' into feat/move-obs-plugins-apm
CoenWarmer Feb 22, 2024
1b124e5
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 23, 2024
e545f86
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine Feb 23, 2024
28ba628
Update references
CoenWarmer Feb 23, 2024
a26253a
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 23, 2024
62b3b2c
Update references
CoenWarmer Feb 23, 2024
68c1f7d
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Feb 23, 2024
ba410e7
Update references
CoenWarmer Feb 23, 2024
fbca8f5
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 23, 2024
7ea7963
Merge branch 'feat/move-obs-plugins-apm' of github.com:CoenWarmer/kib…
CoenWarmer Feb 23, 2024
a6ee399
Update references
CoenWarmer Feb 23, 2024
1fdf207
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 23, 2024
0b2ac86
Fix jest issue
CoenWarmer Feb 23, 2024
7aa46d4
Merge branch 'main' of github.com:elastic/kibana into feat/move-obs-p…
CoenWarmer Feb 23, 2024
d891908
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Feb 23, 2024
0a9f312
Sort registered rules before comparing
CoenWarmer Feb 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 3 additions & 3 deletions .buildkite/ftr_configs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ disabled:
- x-pack/test/functional_enterprise_search/visual_config.ts
- x-pack/test/functional_enterprise_search/cli_config.ts
- x-pack/test_serverless/functional/test_suites/security/cypress/security_config.ts
- x-pack/plugins/apm/ftr_e2e/ftr_config_open.ts
- x-pack/plugins/apm/ftr_e2e/ftr_config_run.ts
- x-pack/plugins/apm/ftr_e2e/ftr_config.ts
- x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config_open.ts
- x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config_run.ts
- x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts
- x-pack/test_serverless/functional/test_suites/observability/cypress/config_headless.ts
- x-pack/test_serverless/functional/test_suites/observability/cypress/config_runner.ts
- x-pack/test/security_solution_cypress/serverless_config.ts
Expand Down
20 changes: 10 additions & 10 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ module.exports = {
'**/*.test.js',
'x-pack/test/apm_api_integration/**/*.ts',
'x-pack/test/functional/apps/**/*.js',
'x-pack/plugins/apm/**/*.js',
'x-pack/plugins/observability_solution/apm/**/*.js',
'test/*/config.ts',
'test/*/config_open.ts',
'test/*/*.config.ts',
Expand Down Expand Up @@ -871,7 +871,7 @@ module.exports = {
*/
{
files: [
'x-pack/plugins/apm/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability_solution/apm/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability_solution/exploratory_view/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability_solution/ux/**/*.{js,mjs,ts,tsx}',
Expand All @@ -894,7 +894,7 @@ module.exports = {
},
{
files: [
'x-pack/plugins/apm/**/*.stories.*',
'x-pack/plugins/observability_solution/apm/**/*.stories.*',
'x-pack/plugins/observability/**/*.stories.*',
'x-pack/plugins/observability_solution/exploratory_view/**/*.stories.*',
],
Expand All @@ -911,16 +911,17 @@ module.exports = {
{
files: [
'x-pack/plugins/aiops/**/*.tsx',
'x-pack/plugins/apm/**/*.tsx',
'x-pack/plugins/observability_solution/exploratory_view/**/*.tsx',
'x-pack/plugins/infra/**/*.tsx',
'x-pack/plugins/observability/**/*.tsx',
'x-pack/plugins/observability_solution/observability_onboarding/**/*.tsx',
'x-pack/plugins/observability_solution/apm/**/*.tsx',
'x-pack/plugins/observability_solution/dataset_quality/**/*.tsx',
'x-pack/plugins/observability_solution/exploratory_view/**/*.tsx',
'x-pack/plugins/observability_solution/observability_ai_assistant/**/*.tsx',
'x-pack/plugins/observability_solution/observability_onboarding/**/*.tsx',
'x-pack/plugins/observability_solution/observability_shared/**/*.tsx',
'x-pack/plugins/observability_solution/profiling/**/*.tsx',
'x-pack/plugins/observability_solution/synthetics/**/*.tsx',
'x-pack/plugins/observability_solution/uptime/**/*.tsx',
'x-pack/plugins/observability_solution/ux/**/*.tsx',
'src/plugins/ai_assistant_management/**/*.tsx',
],
Expand All @@ -930,11 +931,10 @@ module.exports = {
},
{
files: [
'x-pack/plugins/apm/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/exploratory_view/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/infra/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/observability_onboarding/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/apm/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/exploratory_view/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/observability_ai_assistant/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/observability_onboarding/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/plugins/observability_solution/observability_shared/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
Expand All @@ -950,7 +950,7 @@ module.exports = {
},
{
// require explicit return types in route handlers for performance reasons
files: ['x-pack/plugins/apm/server/**/route.ts'],
files: ['x-pack/plugins/observability_solution/apm/server/**/route.ts'],
rules: {
'@typescript-eslint/explicit-function-return-type': [
'error',
Expand Down
6 changes: 3 additions & 3 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ packages/analytics/shippers/elastic_v3/common @elastic/kibana-core
packages/analytics/shippers/elastic_v3/server @elastic/kibana-core
packages/analytics/shippers/fullstory @elastic/kibana-core
packages/kbn-apm-config-loader @elastic/kibana-core @vigneshshanmugam
x-pack/plugins/apm_data_access @elastic/obs-knowledge-team @elastic/obs-ux-infra_services-team
x-pack/plugins/apm @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/apm_data_access @elastic/obs-knowledge-team @elastic/obs-ux-infra_services-team
x-pack/plugins/observability_solution/apm @elastic/obs-ux-infra_services-team
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
packages/kbn-apm-synthtrace-client @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
packages/kbn-apm-utils @elastic/obs-ux-infra_services-team
Expand Down Expand Up @@ -1539,7 +1539,7 @@ x-pack/plugins/security_solution/server/lib/security_integrations @elastic/secur
**/*.scss @elastic/kibana-design

# Observability design
/x-pack/plugins/apm/**/*.scss @elastic/observability-design
/x-pack/plugins/observability_solution/apm/**/*.scss @elastic/observability-design
/x-pack/plugins/infra/**/*.scss @elastic/observability-design
/x-pack/plugins/fleet/**/*.scss @elastic/observability-design
/x-pack/plugins/monitoring/**/*.scss @elastic/observability-design
Expand Down
2 changes: 1 addition & 1 deletion .github/paths-labeller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
- 'src/plugins/expressions/**/*.*'
- 'src/plugins/bfetch/**/*.*'
- 'Team:obs-ux-infra_services':
- 'x-pack/plugins/apm/**/*.*'
- 'x-pack/plugins/observability_solution/apm/**/*.*'
- 'x-pack/test/apm_api_integration/**/*.*'
- 'packages/kbn-apm-synthtrace/**/*.*'
- 'packages/kbn-apm-synthtrace-client/**/*.*'
Expand Down
5 changes: 2 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ npm-debug.log*
## @cypress/snapshot from apm plugin
/snapshots.js
/apm-diagnostics*.json
/x-pack/plugins/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.actual.png
/x-pack/plugins/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.diff.png
/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.actual.png
/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/service_map/snapshots/*.diff.png

# transpiled cypress config
x-pack/plugins/fleet/cypress.config.d.ts
Expand Down Expand Up @@ -141,4 +141,3 @@ x-pack/test/security_api_integration/plugins/audit_log/audit.log
# ignore FTR temp directory
.ftr
role_users.json

96 changes: 39 additions & 57 deletions api_docs/apm.devdocs.json

Large diffs are not rendered by default.

28 changes: 12 additions & 16 deletions api_docs/apm_data_access.devdocs.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"signature": [
"{ readonly indices: Readonly<{} & { error: string; transaction: string; span: string; metric: string; onboarding: string; sourcemap: string; }>; }"
],
"path": "x-pack/plugins/apm_data_access/server/index.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/index.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
Expand All @@ -39,7 +39,7 @@
"signature": [
"{ readonly error: string; readonly transaction: string; readonly span: string; readonly metric: string; readonly onboarding: string; readonly sourcemap: string; }"
],
"path": "x-pack/plugins/apm_data_access/server/index.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/index.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
Expand All @@ -53,7 +53,7 @@
"tags": [],
"label": "ApmDataAccessPluginSetup",
"description": [],
"path": "x-pack/plugins/apm_data_access/server/types.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/types.ts",
"deprecated": false,
"trackAdoption": false,
"children": [
Expand All @@ -67,7 +67,7 @@
"signature": [
"{ readonly error: string; readonly transaction: string; readonly span: string; readonly metric: string; readonly onboarding: string; readonly sourcemap: string; }"
],
"path": "x-pack/plugins/apm_data_access/server/types.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/types.ts",
"deprecated": false,
"trackAdoption": false
},
Expand All @@ -89,7 +89,7 @@
},
") => Promise<Readonly<{} & { error: string; transaction: string; span: string; metric: string; onboarding: string; sourcemap: string; }>>"
],
"path": "x-pack/plugins/apm_data_access/server/types.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/types.ts",
"deprecated": false,
"trackAdoption": false,
"children": [
Expand All @@ -109,7 +109,7 @@
"text": "SavedObjectsClientContract"
}
],
"path": "x-pack/plugins/apm_data_access/server/types.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/types.ts",
"deprecated": false,
"trackAdoption": false,
"isRequired": true
Expand All @@ -128,7 +128,7 @@
"tags": [],
"label": "ApmDataAccessPluginStart",
"description": [],
"path": "x-pack/plugins/apm_data_access/server/types.ts",
"path": "x-pack/plugins/observability_solution/apm_data_access/server/types.ts",
"deprecated": false,
"trackAdoption": false,
"children": [],
Expand All @@ -149,10 +149,8 @@
"tags": [],
"label": "PLUGIN_ID",
"description": [],
"signature": [
"\"apmDataAccess\""
],
"path": "x-pack/plugins/apm_data_access/common/index.ts",
"signature": ["\"apmDataAccess\""],
"path": "x-pack/plugins/observability_solution/apm_data_access/common/index.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
Expand All @@ -164,15 +162,13 @@
"tags": [],
"label": "PLUGIN_NAME",
"description": [],
"signature": [
"\"apmDataAccess\""
],
"path": "x-pack/plugins/apm_data_access/common/index.ts",
"signature": ["\"apmDataAccess\""],
"path": "x-pack/plugins/observability_solution/apm_data_access/common/index.ts",
"deprecated": false,
"trackAdoption": false,
"initialIsOpen": false
}
],
"objects": []
}
}
}
Loading