Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Finish onboarding page "Add Integration" section #176917

Merged
merged 7 commits into from
Feb 27, 2024
Merged

[Security Solution] Finish onboarding page "Add Integration" section #176917

merged 7 commits into from
Feb 27, 2024

Conversation

semd
Copy link
Contributor

@semd semd commented Feb 14, 2024 •
edited by kibanamachine
Loading

Summary

Issue: #175697
Part of: #174742

Updated the "Add Integrations" step on the Onboarding page

  • "Add Cloud Security Data" => /app/integrations/browse/security/cloudsecurity_cdr
  • "Add EDR/XDR Data" => /app/integrations/browse/security/edr_xdr
  • "All Security Integrations" => /app/integrations/browse/security

Before
old

Now
new

@semd semd self-assigned this Feb 14, 2024
@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.13.0 labels Feb 14, 2024
@semd
Copy link
Contributor Author

semd commented Feb 14, 2024

/ci

@semd semd changed the title [Security Solution] Update Onboarding Add Integration step [Security Solution] Fix Onboarding page "Add Integration" Feb 14, 2024
@semd semd changed the title [Security Solution] Fix Onboarding page "Add Integration" [Security Solution] Finish onboarding page "Add Integration" section Feb 15, 2024
@semd semd marked this pull request as ready for review February 15, 2024 09:42
@semd semd requested a review from a team as a code owner February 15, 2024 09:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@semd
Copy link
Contributor Author

semd commented Feb 15, 2024

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Feb 15, 2024

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Feb 21, 2024

@elasticmachine merge upstream

angorayc
angorayc approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this @semd 👍 👍 👍

@semd
Copy link
Contributor Author

semd commented Feb 27, 2024

@elasticmachine merge upstream

@semd semd enabled auto-merge (squash) February 27, 2024 13:13
@semd
Copy link
Contributor Author

semd commented Feb 27, 2024

@elasticmachine merge upstream

@semd
Copy link
Contributor Author

semd commented Feb 27, 2024

@elasticmachine merge upstream

@semd semd merged commit 885e74b into elastic:main Feb 27, 2024
37 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +4.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 27, 2024
@semd
[Security Solution] Finish onboarding page "Add Integration" section (e…
5e09076 
…lastic#176917)

(cherry picked from commit 885e74b)
@kibanamachine kibanamachine mentioned this pull request Feb 27, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 27, 2024
@kibanamachine @semd
[8.13] [Security Solution] Finish onboarding page "Add Integrati…
a137eff 
…on" section (#176917) (#177823)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution] Finish onboarding page "Add
Integration" section
(#176917)](#176917)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-27T20:07:25Z","message":"[Security
Solution] Finish onboarding page \"Add Integration\" section
(#176917)","sha":"885e74b57415937635a6b4b71b3882f33e16ea62","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","v8.13.0","v8.14.0"],"title":"[Security Solution]
Finish onboarding page \"Add Integration\"
section","number":176917,"url":"https://github.com/elastic/kibana/pull/176917","mergeCommit":{"message":"[Security
Solution] Finish onboarding page \"Add Integration\" section
(#176917)","sha":"885e74b57415937635a6b4b71b3882f33e16ea62"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176917","number":176917,"mergeCommit":{"message":"[Security
Solution] Finish onboarding page \"Add Integration\" section
(#176917)","sha":"885e74b57415937635a6b4b71b3882f33e16ea62"}}]}]
BACKPORT-->

Co-authored-by: Sergi Massaneda <[email protected]>
semd added a commit to semd/kibana that referenced this pull request Mar 4, 2024
@semd
[Security Solution] Finish onboarding page "Add Integration" section (e…
c09ae55 
…lastic#176917)
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@semd @fkanout
[Security Solution] Finish onboarding page "Add Integration" section (e…
f058f86 
…lastic#176917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@semd semd

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.13.0 v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@semd @elasticmachine @kibana-ci @kibanamachine @angorayc