[Fleet] Fix wrong policy_id in dev tools flyout request #176729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
the
Team:Fleet
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
criamico
added
the
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
added
the
backport:prev-minor
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @criamico |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2024
Fixes elastic#172798 ## Summary Small bug fix: when adding a new integration, the `policy_id` in dev tools flyout request was not correct Steps to reproduce: - Add one agent policy to the stack - Go to any integration and navigate to `add integration` page - Switch to `Existing hosts` and select an existing policy. - Open `Preview API request`. The policy id in the preview should be the one from the selected policy - Switch back to `New hosts` - Open `Preview API request`. The policy id should be `<agent_policy_id>` again (not the one from the previously selected policy)  (cherry picked from commit 466a05a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2024
…) (#176800) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] Fix wrong policy_id in dev tools flyout request (#176729)](#176729) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-13T10:02:20Z","message":"[Fleet] Fix wrong policy_id in dev tools flyout request (#176729)\n\nFixes https://github.com/elastic/kibana/issues/172798\r\n\r\n## Summary\r\nSmall bug fix: when adding a new integration, the `policy_id` in dev\r\ntools flyout request was not correct\r\n\r\nSteps to reproduce:\r\n\r\n- Add one agent policy to the stack\r\n- Go to any integration and navigate to `add integration` page\r\n- Switch to `Existing hosts` and select an existing policy. \r\n- Open `Preview API request`. The policy id in the preview should be the\r\none from the selected policy\r\n- Switch back to `New hosts`\r\n- Open `Preview API request`. The policy id should be\r\n`<agent_policy_id>` again (not the one from the previously selected\r\npolicy)\r\n\r\n","sha":"466a05ae843f3aeefaa035121dbb9e642bd0eed6","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.13.0"],"title":"[Fleet] Fix wrong policy_id in dev tools flyout request","number":176729,"url":"https://github.com/elastic/kibana/pull/176729","mergeCommit":{"message":"[Fleet] Fix wrong policy_id in dev tools flyout request (#176729)\n\nFixes https://github.com/elastic/kibana/issues/172798\r\n\r\n## Summary\r\nSmall bug fix: when adding a new integration, the `policy_id` in dev\r\ntools flyout request was not correct\r\n\r\nSteps to reproduce:\r\n\r\n- Add one agent policy to the stack\r\n- Go to any integration and navigate to `add integration` page\r\n- Switch to `Existing hosts` and select an existing policy. \r\n- Open `Preview API request`. The policy id in the preview should be the\r\none from the selected policy\r\n- Switch back to `New hosts`\r\n- Open `Preview API request`. The policy id should be\r\n`<agent_policy_id>` again (not the one from the previously selected\r\npolicy)\r\n\r\n","sha":"466a05ae843f3aeefaa035121dbb9e642bd0eed6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/176729","number":176729,"mergeCommit":{"message":"[Fleet] Fix wrong policy_id in dev tools flyout request (#176729)\n\nFixes https://github.com/elastic/kibana/issues/172798\r\n\r\n## Summary\r\nSmall bug fix: when adding a new integration, the `policy_id` in dev\r\ntools flyout request was not correct\r\n\r\nSteps to reproduce:\r\n\r\n- Add one agent policy to the stack\r\n- Go to any integration and navigate to `add integration` page\r\n- Switch to `Existing hosts` and select an existing policy. \r\n- Open `Preview API request`. The policy id in the preview should be the\r\none from the selected policy\r\n- Switch back to `New hosts`\r\n- Open `Preview API request`. The policy id should be\r\n`<agent_policy_id>` again (not the one from the previously selected\r\npolicy)\r\n\r\n","sha":"466a05ae843f3aeefaa035121dbb9e642bd0eed6"}}]}] BACKPORT--> Co-authored-by: Cristina Amico <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
Fixes elastic#172798 ## Summary Small bug fix: when adding a new integration, the `policy_id` in dev tools flyout request was not correct Steps to reproduce: - Add one agent policy to the stack - Go to any integration and navigate to `add integration` page - Switch to `Existing hosts` and select an existing policy. - Open `Preview API request`. The policy id in the preview should be the one from the selected policy - Switch back to `New hosts` - Open `Preview API request`. The policy id should be `<agent_policy_id>` again (not the one from the previously selected policy) 
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
Fixes elastic#172798 ## Summary Small bug fix: when adding a new integration, the `policy_id` in dev tools flyout request was not correct Steps to reproduce: - Add one agent policy to the stack - Go to any integration and navigate to `add integration` page - Switch to `Existing hosts` and select an existing policy. - Open `Preview API request`. The policy id in the preview should be the one from the selected policy - Switch back to `New hosts` - Open `Preview API request`. The policy id should be `<agent_policy_id>` again (not the one from the previously selected policy) 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172798
Summary
Small bug fix: when adding a new integration, the
policy_idin dev tools flyout request was not correctSteps to reproduce:
add integrationpageExisting hostsand select an existing policy.Preview API request. The policy id in the preview should be the one from the selected policyNew hostsPreview API request. The policy id should be<agent_policy_id>again (not the one from the previously selected policy)