Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][color mapping] hide single color picker in loop mode #176564

Merged

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Feb 9, 2024

Summary

This PR hides the single color picker when the color palette is selected in the button group as agreed with @MichaelMarcialis and @stratoula (initial conversation here #175144 followed by an offline one)

From this:
Screenshot 2024-02-09 at 09 20 37

To this:
Screenshot 2024-02-09 at 09 19 51
Screenshot 2024-02-09 at 09 19 48

@markov00 markov00 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting labels Feb 9, 2024
@markov00 markov00 requested a review from a team as a code owner February 9, 2024 08:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great, LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -216.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 merged commit 421c937 into elastic:main Feb 9, 2024
17 checks passed
@markov00 markov00 deleted the 2024-02-09_remove-single-color-picker branch February 9, 2024 14:26
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…176564)

## Summary

This PR hides the single color picker when the color palette is selected
in the button group as agreed with @MichaelMarcialis and @stratoula
(initial conversation here elastic#175144
followed by an offline one)

From this:
<img width="362" alt="Screenshot 2024-02-09 at 09 20 37"
src="https://github.com/elastic/kibana/assets/1421091/5f68fc57-627b-45b7-90e8-1aa78ee4b5b2">

To this:
<img width="376" alt="Screenshot 2024-02-09 at 09 19 51"
src="https://github.com/elastic/kibana/assets/1421091/fbefee5b-74e2-48e0-937b-c9e8e4699dce">
<img width="371" alt="Screenshot 2024-02-09 at 09 19 48"
src="https://github.com/elastic/kibana/assets/1421091/677c1f7f-c02f-4d77-a18f-ea2ffd22f874">
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…176564)

## Summary

This PR hides the single color picker when the color palette is selected
in the button group as agreed with @MichaelMarcialis and @stratoula
(initial conversation here elastic#175144
followed by an offline one)

From this:
<img width="362" alt="Screenshot 2024-02-09 at 09 20 37"
src="https://github.com/elastic/kibana/assets/1421091/5f68fc57-627b-45b7-90e8-1aa78ee4b5b2">

To this:
<img width="376" alt="Screenshot 2024-02-09 at 09 19 51"
src="https://github.com/elastic/kibana/assets/1421091/fbefee5b-74e2-48e0-937b-c9e8e4699dce">
<img width="371" alt="Screenshot 2024-02-09 at 09 19 48"
src="https://github.com/elastic/kibana/assets/1421091/677c1f7f-c02f-4d77-a18f-ea2ffd22f874">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants