-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens][color mapping] hide single color picker in loop mode #176564
Merged
markov00
merged 2 commits into
elastic:main
from
markov00:2024-02-09_remove-single-color-picker
Feb 9, 2024
Merged
[Lens][color mapping] hide single color picker in loop mode #176564
markov00
merged 2 commits into
elastic:main
from
markov00:2024-02-09_remove-single-color-picker
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
enhancement
New value added to drive a business result
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
release_note:skip
Skip the PR/issue when compiling release notes
Feature:Lens
backport:skip
This commit does not require backporting
labels
Feb 9, 2024
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
stratoula
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great, LGTM!
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…176564) ## Summary This PR hides the single color picker when the color palette is selected in the button group as agreed with @MichaelMarcialis and @stratoula (initial conversation here elastic#175144 followed by an offline one) From this: <img width="362" alt="Screenshot 2024-02-09 at 09 20 37" src="https://github.com/elastic/kibana/assets/1421091/5f68fc57-627b-45b7-90e8-1aa78ee4b5b2"> To this: <img width="376" alt="Screenshot 2024-02-09 at 09 19 51" src="https://github.com/elastic/kibana/assets/1421091/fbefee5b-74e2-48e0-937b-c9e8e4699dce"> <img width="371" alt="Screenshot 2024-02-09 at 09 19 48" src="https://github.com/elastic/kibana/assets/1421091/677c1f7f-c02f-4d77-a18f-ea2ffd22f874">
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…176564) ## Summary This PR hides the single color picker when the color palette is selected in the button group as agreed with @MichaelMarcialis and @stratoula (initial conversation here elastic#175144 followed by an offline one) From this: <img width="362" alt="Screenshot 2024-02-09 at 09 20 37" src="https://github.com/elastic/kibana/assets/1421091/5f68fc57-627b-45b7-90e8-1aa78ee4b5b2"> To this: <img width="376" alt="Screenshot 2024-02-09 at 09 19 51" src="https://github.com/elastic/kibana/assets/1421091/fbefee5b-74e2-48e0-937b-c9e8e4699dce"> <img width="371" alt="Screenshot 2024-02-09 at 09 19 48" src="https://github.com/elastic/kibana/assets/1421091/677c1f7f-c02f-4d77-a18f-ea2ffd22f874">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
enhancement
New value added to drive a business result
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v8.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR hides the single color picker when the color palette is selected in the button group as agreed with @MichaelMarcialis and @stratoula (initial conversation here #175144 followed by an offline one)
From this:
To this: