Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Allow to store the configured ES|QL visualization v3 (with migrations) #176530

Closed

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Feb 8, 2024

Tmp PR for running CI. Main PR: #175227

Includes:

  • Creates saved-search-so plugin and saved-search package to extract some common code from saved-search plugin and avoid circular deps when requiring lens plugin
  • Adds Lens migrations for the new visContextJSON attribute in a saved search SO
  • Adds tests for lens migrations

jughosta and others added 30 commits January 5, 2024 17:50
… src/core/server/integration_tests/ci_checks'
…earch

# Conflicts:
#	src/plugins/discover/public/application/main/components/layout/use_discover_histogram.ts
Copy link
Contributor

github-actions bot commented Feb 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@jughosta
Copy link
Contributor Author

jughosta commented Feb 8, 2024

/ci

@jughosta
Copy link
Contributor Author

jughosta commented Feb 9, 2024

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #15 / cloud_security_posture GET /internal/cloud_security_posture/status STATUS = INDEX_TIMEOUT TEST Should return index-timeout when installed cnvm, has findings only on logs-cloud_security_posture.vulnerabilities-default* and it has been more than 4 hours minutes since the installation

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
savedSearch 47 49 +2
unifiedHistogram 121 128 +7
total +9

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/saved-search - 3 +3
savedSearch 77 78 +1
unifiedHistogram 23 27 +4
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 572.3KB 573.5KB +1.1KB
lens 1.4MB 1.4MB +113.0B
observabilityAIAssistant 168.6KB 168.6KB +45.0B
unifiedHistogram 70.3KB 75.9KB +5.7KB
total +7.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/saved-search - 3 +3
savedSearch 3 2 -1
unifiedHistogram 2 4 +2
total +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedSearch 11.5KB 11.5KB -2.0B
unifiedHistogram 6.4KB 7.6KB +1.2KB
total +1.2KB
Unknown metric groups

API count

id before after diff
@kbn/saved-search - 3 +3
savedSearch 78 79 +1
unifiedHistogram 55 60 +5
total +9

ESLint disabled in files

id before after diff
savedSearch 1 0 -1

References to deprecated APIs

id before after diff
savedSearch 9 4 -5
savedSearchSo - 5 +5
total -0

Total ESLint disabled count

id before after diff
savedSearch 3 2 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jughosta jughosta closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants