[Security Solution] Per-field diffs test plan #176474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplumlee
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
buildkite test this |
💚 Build Succeeded
To update your PR or re-run it, just comment with: cc @dplumlee |
jpdjere
reviewed
Feb 9, 2024
| The <field> diff accordion panel should display its grouped rule properties | ||
| And each property should have its name displayed inside the panel above its value | ||
|
|
||
| Examples: |
There was a problem hiding this comment.
This looks good 👍
I think these cases are limited enough that we should have a test case for each (+ one more for normal "ungrouped" fields), as you defined here.
I would just change the word "Examples" for "CASES:"
There was a problem hiding this comment.
@jpdjere Examples is actually a keyword. Basically, this is how you say "cases" in Gherkin.
https://cucumber.io/docs/gherkin/reference/#examples
jpdjere
reviewed
Feb 9, 2024
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
banderror
reviewed
Feb 9, 2024
| The <field> diff accordion panel should display its grouped rule properties | ||
| And each property should have its name displayed inside the panel above its value | ||
|
|
||
| CASES: |
There was a problem hiding this comment.
Since it's a text block in Gherkin: #176474 (comment)
jpdjere
approved these changes
Feb 12, 2024
2 tasks
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Resolves elastic#176473 This PR introduces a test plan for the per-field diff preview. This preview is displayed in the upgrade prebuilt rule flyout under the `Updates` tab. <img width="1538" alt="Screenshot 2024-02-08 at 1 35 05 AM" src="https://github.com/elastic/kibana/assets/56367316/37e25106-f4a5-47e6-9d93-beab8d0f90a4">
17 tasks
dplumlee
added a commit
that referenced
this pull request
Feb 22, 2024
## Summary Addresses test coverage acceptance criteria for #166489 Adds test coverage in accordance to the recently merged [test plan](#176474) [Flaky test runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 22, 2024
## Summary Addresses test coverage acceptance criteria for elastic#166489 Adds test coverage in accordance to the recently merged [test plan](elastic#176474) [Flaky test runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279) (cherry picked from commit 3c34b53)
kibanamachine
referenced
this pull request
Feb 22, 2024
…177645) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution] Per-field diffs test coverage (#177399)](#177399) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Davis Plumlee","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-22T19:57:41Z","message":"[Security Solution] Per-field diffs test coverage (#177399)\n\n## Summary\r\n\r\nAddresses test coverage acceptance criteria for\r\nhttps://github.com//issues/166489\r\n\r\nAdds test coverage in accordance to the recently merged [test\r\nplan](https://github.com/elastic/kibana/pull/176474)\r\n\r\n[Flaky test\r\nrunner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279)","sha":"3c34b535ceac5a5c869719998d9e03a0d44ce21a","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-coverage","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.13.0","v8.14.0"],"title":"[Security Solution] Per-field diffs test coverage","number":177399,"url":"https://github.com/elastic/kibana/pull/177399","mergeCommit":{"message":"[Security Solution] Per-field diffs test coverage (#177399)\n\n## Summary\r\n\r\nAddresses test coverage acceptance criteria for\r\nhttps://github.com//issues/166489\r\n\r\nAdds test coverage in accordance to the recently merged [test\r\nplan](https://github.com/elastic/kibana/pull/176474)\r\n\r\n[Flaky test\r\nrunner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279)","sha":"3c34b535ceac5a5c869719998d9e03a0d44ce21a"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177399","number":177399,"mergeCommit":{"message":"[Security Solution] Per-field diffs test coverage (#177399)\n\n## Summary\r\n\r\nAddresses test coverage acceptance criteria for\r\nhttps://github.com//issues/166489\r\n\r\nAdds test coverage in accordance to the recently merged [test\r\nplan](https://github.com/elastic/kibana/pull/176474)\r\n\r\n[Flaky test\r\nrunner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279)","sha":"3c34b535ceac5a5c869719998d9e03a0d44ce21a"}}]}] BACKPORT--> Co-authored-by: Davis Plumlee <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Resolves elastic#176473 This PR introduces a test plan for the per-field diff preview. This preview is displayed in the upgrade prebuilt rule flyout under the `Updates` tab. <img width="1538" alt="Screenshot 2024-02-08 at 1 35 05 AM" src="https://github.com/elastic/kibana/assets/56367316/37e25106-f4a5-47e6-9d93-beab8d0f90a4">
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Addresses test coverage acceptance criteria for elastic#166489 Adds test coverage in accordance to the recently merged [test plan](elastic#176474) [Flaky test runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #176473
This PR introduces a test plan for the per-field diff preview. This preview is displayed in the upgrade prebuilt rule flyout under the
Updatestab.