[8.12] [Profiling,Infra,APM] Disable Profiling integration by default (#175201) #176406
+100
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic#175201) Closes elastic#175016 ## Summary This PR disables the Profiling integration in Infra and APM by default on the plugin configuration level because this integration require users to first configure the main `profiling` plugin. On-prem users will have to manually enable both integrations once they enabled the Universal Profiling for their hosts. Cloud users will have Infra and APM integrations enabled by default because on Cloud instances Universal Profiling is already configured. A PR for the default Cloud settings will follow after this one is merged. Changes I've made: * Disabled the Infra integration be default * Introduced a new APM feature flag for the Profiling integration * Made sure all the places in APM that rely on Profiling integration respect the new feature flag * Fixed a bug in APM when Universal Profiling was shown even though the integration was disabled in UI settings https://github.com/elastic/kibana/assets/793851/65dfbb5b-1850-4d18-a92a-6ad59e0436a3 ## How To Test 1. Checkout locally 2. Make sure you don't have `xpack.infra.featureFlags.profilingEnabled` already enabled in `kibana.yml` 3. Open kibana and make sure you don't see "Universal Profiling" tab in Host and Service details 4. Enabled both flags in `kibana.yml`: `xpack.infra.featureFlags.profilingEnabled` and `xpack.apm.featureFlags.profilingIntegrationAvailable: true` 5. Check that now you see "Universal Profiling" tab in the details screens in both Infra and APM 6. Go to Infra settings view and disable the Profiling integration, make sure the tab disappears 7. 6. Go to APM settings view and disable the Profiling integration, make sure the tab disappears --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit abd3515) # Conflicts: # x-pack/plugins/apm/public/components/app/settings/general_settings/index.tsx # x-pack/plugins/apm/public/components/shared/transaction_action_menu/transaction_action_menu.test.tsx
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
cauemarcondes
approved these changes
Feb 7, 2024
|
Pinging @elastic/apm-ui (Team:APM) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.12:Questions ?
Please refer to the Backport tool documentation