[DOCS][MAPS] Updates to the asset tracking tutorial targeting 8.12 #175973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyjtechwriter
added
backport
release_note:skip
|
Documentation preview: |
jsanz
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Looks good to me, thanks for backporting this! A couple of comments, not blocking the merge.
- You did not remove the files unused as I did in [Docs][Maps] Update the asset tracking tutorial #173999, any reason for that?
- The tutorial files are basically the same but I see you did some improvements like removing unnecessary blank lines, trailing spaces. Should we align this file with
mainso this work is available for future versions?
To compare this PR tutorial with main I run
diff \
<(curl -s https://raw.githubusercontent.com/elastic/kibana/12a7988fe4199e62e7e72cea2bb678378b8ac399/docs/maps/asset-tracking-tutorial.asciidoc) \
<(curl -s https://raw.githubusercontent.com/elastic/kibana/main/docs/maps/asset-tracking-tutorial.asciidoc)
jsanz
added a commit
that referenced
this pull request
Feb 2, 2024
…6061) This PR incorporates some linting fixes to the asset tracking tutorial that @amyjtechwriter added to the backport done to 8.12 of #173999 at #175973.
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
…stic#176061) This PR incorporates some linting fixes to the asset tracking tutorial that @amyjtechwriter added to the backport done to 8.12 of elastic#173999 at elastic#175973.
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…stic#176061) This PR incorporates some linting fixes to the asset tracking tutorial that @amyjtechwriter added to the backport done to 8.12 of elastic#173999 at elastic#175973.
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…stic#176061) This PR incorporates some linting fixes to the asset tracking tutorial that @amyjtechwriter added to the backport done to 8.12 of elastic#173999 at elastic#175973.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the updates made to the asset tracking tutorial to 8.12.
Closes: #175522. <-- User feedback that steps might have been missing. Myself and the user were looking at the previous version of the tutorial.
Copy of: #173999 <-- Jorge's updates to the tutorial.