[Response Ops][Actions] Adding configuration to override default MS Graph API Scope and Exchange URL values #175812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L configurable
|
/ci |
ymao1
changed the title
|
/ci |
ymao1
added
Feature:Actions
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
commented
Jan 29, 2024
|
|
||
| `xpack.actions.microsoftGraphApiScope`:: | ||
| The URL for the Microsoft Graph API scope endpoint to use for MS Exchange email authentication. Default: `https://graph.microsoft.com/.default`. | ||
|
|
There was a problem hiding this comment.
@lcawl Can you review the wording here?
ymao1
added
v8.12.1
backport:prev-minor
|
@elasticmachine merge upstream |
ersin-erdal
reviewed
Feb 1, 2024
x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
|
@elasticmachine run elasticsearch-ci/docs |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 1, 2024
…raph API Scope and Exchange URL values (elastic#175812) Resolves elastic#166064 ## Summary Adds the following configurations to the `kibana.yml` config: * `xpack.actions.microsoftGraphApiScope` - overrides the default Graph API scope value of `https://graph.microsoft.com/.default` * `xpack.actions.microsoftExchangeUrl` - overrides the default value of `https://login.microsoftonline.com` This allows users in different Azure environments to customize their endpoints as needed. ## To Verify We are unable to test this in a different environment but we can verify that the config overrides the defaults as expected by setting the config values to something different and the logging out the params that are sent to `getOAuthClientCredentialsAccessToken` in `x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`. Then create an MS Exchange email connector and test it to see that the logged values are overridden as expected. --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit f7e4f7a)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Feb 1, 2024
…raph API Scope and Exchange URL values (elastic#175812) Resolves elastic#166064 ## Summary Adds the following configurations to the `kibana.yml` config: * `xpack.actions.microsoftGraphApiScope` - overrides the default Graph API scope value of `https://graph.microsoft.com/.default` * `xpack.actions.microsoftExchangeUrl` - overrides the default value of `https://login.microsoftonline.com` This allows users in different Azure environments to customize their endpoints as needed. ## To Verify We are unable to test this in a different environment but we can verify that the config overrides the defaults as expected by setting the config values to something different and the logging out the params that are sent to `getOAuthClientCredentialsAccessToken` in `x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`. Then create an MS Exchange email connector and test it to see that the logged values are overridden as expected. --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit f7e4f7a) # Conflicts: # docs/settings/alert-action-settings.asciidoc # x-pack/plugins/actions/common/index.ts # x-pack/plugins/actions/server/actions_client/actions_client.test.ts # x-pack/plugins/actions/server/actions_config.test.ts # x-pack/plugins/actions/server/actions_config.ts # x-pack/plugins/actions/server/builtin_action_types/lib/send_email.test.ts # x-pack/plugins/actions/server/builtin_action_types/lib/send_email.ts # x-pack/plugins/actions/server/config.test.ts # x-pack/plugins/actions/server/config.ts # x-pack/plugins/actions/server/integration_tests/axios_utils_connection.test.ts # x-pack/plugins/actions/server/integration_tests/axios_utils_proxy.test.ts # x-pack/plugins/actions/server/lib/custom_host_settings.test.ts # x-pack/plugins/actions/server/plugin.test.ts
kibanamachine
added a commit
that referenced
this pull request
Feb 1, 2024
…lt MS Graph API Scope and Exchange URL values (#175812) (#176085) # Backport This will backport the following commits from `main` to `8.12`: - [[Response Ops][Actions] Adding configuration to override default MS Graph API Scope and Exchange URL values (#175812)](#175812) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-01T17:41:52Z","message":"[Response Ops][Actions] Adding configuration to override default MS Graph API Scope and Exchange URL values (#175812)\n\nResolves https://github.com/elastic/kibana/issues/166064\r\n\r\n## Summary\r\n\r\nAdds the following configurations to the `kibana.yml` config:\r\n* `xpack.actions.microsoftGraphApiScope` - overrides the default Graph\r\nAPI scope value of `https://graph.microsoft.com/.default`\r\n* `xpack.actions.microsoftExchangeUrl` - overrides the default value of\r\n`https://login.microsoftonline.com`\r\n\r\nThis allows users in different Azure environments to customize their\r\nendpoints as needed.\r\n\r\n## To Verify\r\n\r\nWe are unable to test this in a different environment but we can verify\r\nthat the config overrides the defaults as expected by setting the config\r\nvalues to something different and the logging out the params that are\r\nsent to `getOAuthClientCredentialsAccessToken` in\r\n`x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`.\r\nThen create an MS Exchange email connector and test it to see that the\r\nlogged values are overridden as expected.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"f7e4f7a636763d46cb6a38b21a5eb6e67595ddfe","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Actions","Team:ResponseOps","backport:prev-minor","backport:prev-MAJOR","v8.13.0"],"title":"[Response Ops][Actions] Adding configuration to override default MS Graph API Scope and Exchange URL values","number":175812,"url":"https://github.com/elastic/kibana/pull/175812","mergeCommit":{"message":"[Response Ops][Actions] Adding configuration to override default MS Graph API Scope and Exchange URL values (#175812)\n\nResolves https://github.com/elastic/kibana/issues/166064\r\n\r\n## Summary\r\n\r\nAdds the following configurations to the `kibana.yml` config:\r\n* `xpack.actions.microsoftGraphApiScope` - overrides the default Graph\r\nAPI scope value of `https://graph.microsoft.com/.default`\r\n* `xpack.actions.microsoftExchangeUrl` - overrides the default value of\r\n`https://login.microsoftonline.com`\r\n\r\nThis allows users in different Azure environments to customize their\r\nendpoints as needed.\r\n\r\n## To Verify\r\n\r\nWe are unable to test this in a different environment but we can verify\r\nthat the config overrides the defaults as expected by setting the config\r\nvalues to something different and the logging out the params that are\r\nsent to `getOAuthClientCredentialsAccessToken` in\r\n`x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`.\r\nThen create an MS Exchange email connector and test it to see that the\r\nlogged values are overridden as expected.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"f7e4f7a636763d46cb6a38b21a5eb6e67595ddfe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175812","number":175812,"mergeCommit":{"message":"[Response Ops][Actions] Adding configuration to override default MS Graph API Scope and Exchange URL values (#175812)\n\nResolves https://github.com/elastic/kibana/issues/166064\r\n\r\n## Summary\r\n\r\nAdds the following configurations to the `kibana.yml` config:\r\n* `xpack.actions.microsoftGraphApiScope` - overrides the default Graph\r\nAPI scope value of `https://graph.microsoft.com/.default`\r\n* `xpack.actions.microsoftExchangeUrl` - overrides the default value of\r\n`https://login.microsoftonline.com`\r\n\r\nThis allows users in different Azure environments to customize their\r\nendpoints as needed.\r\n\r\n## To Verify\r\n\r\nWe are unable to test this in a different environment but we can verify\r\nthat the config overrides the defaults as expected by setting the config\r\nvalues to something different and the logging out the params that are\r\nsent to `getOAuthClientCredentialsAccessToken` in\r\n`x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`.\r\nThen create an MS Exchange email connector and test it to see that the\r\nlogged values are overridden as expected.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"f7e4f7a636763d46cb6a38b21a5eb6e67595ddfe"}}]}] BACKPORT--> Co-authored-by: Ying Mao <[email protected]>
kibanamachine
added
v8.12.1
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
|
This PR didn't make it on time to the latest build candidate of v8.12.1. Updating the labels. |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
…raph API Scope and Exchange URL values (elastic#175812) Resolves elastic#166064 ## Summary Adds the following configurations to the `kibana.yml` config: * `xpack.actions.microsoftGraphApiScope` - overrides the default Graph API scope value of `https://graph.microsoft.com/.default` * `xpack.actions.microsoftExchangeUrl` - overrides the default value of `https://login.microsoftonline.com` This allows users in different Azure environments to customize their endpoints as needed. ## To Verify We are unable to test this in a different environment but we can verify that the config overrides the defaults as expected by setting the config values to something different and the logging out the params that are sent to `getOAuthClientCredentialsAccessToken` in `x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`. Then create an MS Exchange email connector and test it to see that the logged values are overridden as expected. --------- Co-authored-by: Kibana Machine <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…raph API Scope and Exchange URL values (elastic#175812) Resolves elastic#166064 ## Summary Adds the following configurations to the `kibana.yml` config: * `xpack.actions.microsoftGraphApiScope` - overrides the default Graph API scope value of `https://graph.microsoft.com/.default` * `xpack.actions.microsoftExchangeUrl` - overrides the default value of `https://login.microsoftonline.com` This allows users in different Azure environments to customize their endpoints as needed. ## To Verify We are unable to test this in a different environment but we can verify that the config overrides the defaults as expected by setting the config values to something different and the logging out the params that are sent to `getOAuthClientCredentialsAccessToken` in `x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`. Then create an MS Exchange email connector and test it to see that the logged values are overridden as expected. --------- Co-authored-by: Kibana Machine <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…raph API Scope and Exchange URL values (elastic#175812) Resolves elastic#166064 ## Summary Adds the following configurations to the `kibana.yml` config: * `xpack.actions.microsoftGraphApiScope` - overrides the default Graph API scope value of `https://graph.microsoft.com/.default` * `xpack.actions.microsoftExchangeUrl` - overrides the default value of `https://login.microsoftonline.com` This allows users in different Azure environments to customize their endpoints as needed. ## To Verify We are unable to test this in a different environment but we can verify that the config overrides the defaults as expected by setting the config values to something different and the logging out the params that are sent to `getOAuthClientCredentialsAccessToken` in `x-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts`. Then create an MS Exchange email connector and test it to see that the logged values are overridden as expected. --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #166064
Summary
Adds the following configurations to the
kibana.ymlconfig:xpack.actions.microsoftGraphApiScope- overrides the default Graph API scope value ofhttps://graph.microsoft.com/.defaultxpack.actions.microsoftExchangeUrl- overrides the default value ofhttps://login.microsoftonline.comThis allows users in different Azure environments to customize their endpoints as needed.
To Verify
We are unable to test this in a different environment but we can verify that the config overrides the defaults as expected by setting the config values to something different and the logging out the params that are sent to
getOAuthClientCredentialsAccessTokeninx-pack/plugins/stack_connectors/server/connector_types/email/send_email.ts. Then create an MS Exchange email connector and test it to see that the logged values are overridden as expected.