Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for API Key management #175809

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

legrego
Copy link
Member

@legrego legrego commented Jan 29, 2024

Summary

Resolves #166095.

This updates the API Key management screen to reflect the copy adjustments described in #166095:

  1. Change Cross-Cluster to Cross-cluster, unless it is mid-sentence in which case cross-cluster should be used.
  2. Updated ownership & expiry warnings to use the active voice.
  3. Renamed Personal API Keys to User API Keys.

Larry Gregory 2024-01-29 at 10 12 45@2x

Larry Gregory 2024-01-29 at 10 14 02@2x

Larry Gregory 2024-01-29 at 10 15 03@2x

Larry Gregory 2024-01-29 at 10 15 27@2x

View docs changes here: https://kibana_bk_175809.docs-preview.app.elstc.co/diff

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Users/Roles/API Keys release_note:skip Skip the PR/issue when compiling release notes labels Jan 29, 2024
@legrego
Copy link
Member Author

legrego commented Jan 29, 2024

/ci

Copy link
Contributor

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@legrego legrego added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Jan 29, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 580.3KB 580.2KB -51.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego marked this pull request as ready for review January 29, 2024 16:50
@legrego legrego requested a review from a team as a code owner January 29, 2024 16:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content changes LGTM 🚀 Thanks!

@legrego legrego enabled auto-merge (squash) January 29, 2024 18:10
@legrego legrego merged commit 0ac38ec into elastic:main Jan 30, 2024
28 checks passed
@kibanamachine

This comment was marked as outdated.

@legrego legrego added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 30, 2024
@legrego legrego deleted the api-key-copy-tweaks branch January 30, 2024 12:10
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Resolves elastic#166095.

This updates the API Key management screen to reflect the copy
adjustments described in elastic#166095:

1. Change `Cross-Cluster` to `Cross-cluster`, unless it is mid-sentence
in which case `cross-cluster` should be used.
2. Updated ownership & expiry warnings to use the active voice.
3. Renamed `Personal` API Keys to `User` API Keys.


![Larry Gregory 2024-01-29 at 10 12
45@2x](https://github.com/elastic/kibana/assets/3493255/8df4e279-5d68-4353-87aa-e40e6949f528)

![Larry Gregory 2024-01-29 at 10 14
02@2x](https://github.com/elastic/kibana/assets/3493255/290166ea-51a3-43ae-bed4-7278865b1bdc)

![Larry Gregory 2024-01-29 at 10 15
03@2x](https://github.com/elastic/kibana/assets/3493255/97bb6426-e8ce-4bc1-b5ae-44944683978f)


![Larry Gregory 2024-01-29 at 10 15
27@2x](https://github.com/elastic/kibana/assets/3493255/61adfece-05eb-4fbc-bf68-265d5cfaa987)


View docs changes here:
https://kibana_bk_175809.docs-preview.app.elstc.co/diff
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Resolves elastic#166095.

This updates the API Key management screen to reflect the copy
adjustments described in elastic#166095:

1. Change `Cross-Cluster` to `Cross-cluster`, unless it is mid-sentence
in which case `cross-cluster` should be used.
2. Updated ownership & expiry warnings to use the active voice.
3. Renamed `Personal` API Keys to `User` API Keys.


![Larry Gregory 2024-01-29 at 10 12
45@2x](https://github.com/elastic/kibana/assets/3493255/8df4e279-5d68-4353-87aa-e40e6949f528)

![Larry Gregory 2024-01-29 at 10 14
02@2x](https://github.com/elastic/kibana/assets/3493255/290166ea-51a3-43ae-bed4-7278865b1bdc)

![Larry Gregory 2024-01-29 at 10 15
03@2x](https://github.com/elastic/kibana/assets/3493255/97bb6426-e8ce-4bc1-b5ae-44944683978f)


![Larry Gregory 2024-01-29 at 10 15
27@2x](https://github.com/elastic/kibana/assets/3493255/61adfece-05eb-4fbc-bf68-265d5cfaa987)


View docs changes here:
https://kibana_bk_175809.docs-preview.app.elstc.co/diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Users/Roles/API Keys release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cross-cluster API keys] Improve copy for cross-cluster API key management
6 participants