[8.12] chore(NA): add sharp resolution for v0.32.6 (#175720) #175741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#175544 I think what we were seeing around the sharp issue was the same problem of other native modules which is the install step not running and installing the correct native binaries because of corrupted caches when changing branches. Currently moving to v0.33+ will be problematic because we are using yarn v1 so this PR is making a resolution pin which will help on not making the upgrade for the moment as well as to a correct dep installation when resetting the environment. (cherry picked from commit 85013e9) # Conflicts: # yarn.lock
mistic
referenced
this pull request
Jan 27, 2024
# Backport This will backport the following commits from `main` to `7.17`: - [chore(NA): add sharp resolution for v0.32.6 (#175720)](#175720) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-26T21:29:00Z","message":"chore(NA): add sharp resolution for v0.32.6 (#175720)\n\nCloses https://github.com/elastic/kibana/issues/175544\r\n\r\nI think what we were seeing around the sharp issue was the same problem\r\nof other native modules which is the install step not running and\r\ninstalling the correct native binaries because of corrupted caches when\r\nchanging branches.\r\n\r\nCurrently moving to v0.33+ will be problematic because we are using yarn\r\nv1 so this PR is making a resolution pin which will help on not making\r\nthe upgrade for the moment as well as to a correct dep installation when\r\nresetting the environment.","sha":"85013e943b895e09d9df335fbe14dc2ec010dac8","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.13.0"],"number":175720,"url":"https://github.com/elastic/kibana/pull/175720","mergeCommit":{"message":"chore(NA): add sharp resolution for v0.32.6 (#175720)\n\nCloses https://github.com/elastic/kibana/issues/175544\r\n\r\nI think what we were seeing around the sharp issue was the same problem\r\nof other native modules which is the install step not running and\r\ninstalling the correct native binaries because of corrupted caches when\r\nchanging branches.\r\n\r\nCurrently moving to v0.33+ will be problematic because we are using yarn\r\nv1 so this PR is making a resolution pin which will help on not making\r\nthe upgrade for the moment as well as to a correct dep installation when\r\nresetting the environment.","sha":"85013e943b895e09d9df335fbe14dc2ec010dac8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175720","number":175720,"mergeCommit":{"message":"chore(NA): add sharp resolution for v0.32.6 (#175720)\n\nCloses https://github.com/elastic/kibana/issues/175544\r\n\r\nI think what we were seeing around the sharp issue was the same problem\r\nof other native modules which is the install step not running and\r\ninstalling the correct native binaries because of corrupted caches when\r\nchanging branches.\r\n\r\nCurrently moving to v0.33+ will be problematic because we are using yarn\r\nv1 so this PR is making a resolution pin which will help on not making\r\nthe upgrade for the moment as well as to a correct dep installation when\r\nresetting the environment.","sha":"85013e943b895e09d9df335fbe14dc2ec010dac8"}},{"url":"https://github.com/elastic/kibana/pull/175741","number":175741,"branch":"8.12","state":"OPEN"}]}] BACKPORT-->
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.12:Questions ?
Please refer to the Backport tool documentation