[8.12] Tweaks to prompt editor (#174030) #175664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
approved these changes
Jan 26, 2024
CoenWarmer
commented
Jan 26, 2024
...bservability_ai_assistant/public/components/prompt_editor/prompt_editor_natural_language.tsx
Outdated
Show resolved
Hide resolved
CoenWarmer
commented
Jan 26, 2024
...lugins/observability_ai_assistant/public/components/prompt_editor/prompt_editor_function.tsx
Outdated
Show resolved
Hide resolved
CoenWarmer
commented
Jan 26, 2024
...lugins/observability_ai_assistant/public/components/prompt_editor/prompt_editor_function.tsx
Outdated
Show resolved
Hide resolved
## Summary This fixes the following edge case when using the chat interface: * When the main editor has a value in the text area, and the user edits an existing message, and presses `<enter>` on the keyboard, the value that was in the main editor is appended as a new message, instead of editing the existing message. It also does a bit of cleanup (moving of ChatPromptEditor components to `/components/prompt_editor`, and renaming to `PromptEditor`.) ### Additional fixes * [Don't stick to bottom when changing to edit mode, re-stick to bottom when done editing](elastic@e8a01c1) * [Autofocus function popover list search box upon opening](elastic@2329d1c) * [Remove focus trap as it wasn't doing anything anymore](elastic@7fcb4e0) * [Move constants used when creating monaco model inside function scope to avoid sharing of model between multiple editor instances](elastic@c9cab2c) * [Disable submitting function editor when json is not valid](elastic@2a6f1e1) (cherry picked from commit f4265ca) # Conflicts: # x-pack/plugins/observability_ai_assistant/public/components/prompt_editor/prompt_editor_function.tsx
CoenWarmer
force-pushed
the
backport/8.12/pr-174030
branch
from
0682d62 to
30c2ded
Compare
CoenWarmer
commented
Jan 26, 2024
...bservability_ai_assistant/public/components/prompt_editor/prompt_editor_natural_language.tsx
Outdated
Show resolved
Hide resolved
…ompt_editor/prompt_editor_natural_language.tsx
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.12:Questions ?
Please refer to the Backport tool documentation