[Obs AI Assistant] Increase no of max function calls to 5 #175588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
miltonhultgren
approved these changes
Jan 26, 2024
| @@ -147,7 +147,7 @@ export class ObservabilityAIAssistantClient { | |||
|
|
|||
| let numFunctionsCalled: number = 0; | |||
|
|
|||
| const MAX_FUNCTION_CALLS = 3; | |||
| const MAX_FUNCTION_CALLS = 5; | |||
There was a problem hiding this comment.
Wondering if perhaps we should make this a Kibana config?
Or is it perhaps worse to go up to 10? No limit is bad, but how confident are we that the machine is "failing" if it makes it up to 5, compared to 10?
Specially if we add new functions that may play well together, this might be hard to catch. Unless we have some telemetry about this happening?
There was a problem hiding this comment.
10 is a lot. I hesitate to add more config. Let's see if we get reports about this.
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dgieselaar
added a commit
that referenced
this pull request
Jan 26, 2024
…5588) (#175668) # Backport This will backport the following commits from `main` to `8.12`: - [[Obs AI Assistant] Increase no of max function calls to 5 (#175588)](#175588) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-26T09:17:36Z","message":"[Obs AI Assistant] Increase no of max function calls to 5 (#175588)\n\nThe function limit of 3 is too low, it runs into issues w/ ES|QL query\r\ngeneration if the `get_dataset_info` and `execute_query` functions are\r\nused.","sha":"beff74e19e94c7d3c609a2be0cb1d4b2f28da043","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v8.12.1","v8.13.0"],"number":175588,"url":"https://github.com/elastic/kibana/pull/175588","mergeCommit":{"message":"[Obs AI Assistant] Increase no of max function calls to 5 (#175588)\n\nThe function limit of 3 is too low, it runs into issues w/ ES|QL query\r\ngeneration if the `get_dataset_info` and `execute_query` functions are\r\nused.","sha":"beff74e19e94c7d3c609a2be0cb1d4b2f28da043"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175588","number":175588,"mergeCommit":{"message":"[Obs AI Assistant] Increase no of max function calls to 5 (#175588)\n\nThe function limit of 3 is too low, it runs into issues w/ ES|QL query\r\ngeneration if the `get_dataset_info` and `execute_query` functions are\r\nused.","sha":"beff74e19e94c7d3c609a2be0cb1d4b2f28da043"}}]}] BACKPORT-->
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…5588) The function limit of 3 is too low, it runs into issues w/ ES|QL query generation if the `get_dataset_info` and `execute_query` functions are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function limit of 3 is too low, it runs into issues w/ ES|QL query generation if the
get_dataset_infoandexecute_queryfunctions are used.