Reverts erroneous addition of security plugin enabled config option #175565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
added
Team:Security
|
/ci |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jeramysoucy |
|
Pinging @elastic/kibana-security (Team:Security) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 26, 2024
…lastic#175565) ## Summary In elastic#155582, an `enabled` option was added to the `Security` plugin. This option is not supported or documented. This PR reverts that change. (cherry picked from commit 4385dc1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 26, 2024
…ption (#175565) (#175692) # Backport This will backport the following commits from `main` to `8.12`: - [Reverts erroneous addition of security plugin enabled config option (#175565)](#175565) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jeramy Soucy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-26T15:16:03Z","message":"Reverts erroneous addition of security plugin enabled config option (#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added to the `Security` plugin. This\r\noption is not supported or documented. This PR reverts that change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","backport:prev-minor","v8.13.0"],"title":"Reverts erroneous addition of security plugin enabled config option","number":175565,"url":"https://github.com/elastic/kibana/pull/175565","mergeCommit":{"message":"Reverts erroneous addition of security plugin enabled config option (#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added to the `Security` plugin. This\r\noption is not supported or documented. This PR reverts that change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175565","number":175565,"mergeCommit":{"message":"Reverts erroneous addition of security plugin enabled config option (#175565)\n\n## Summary\r\n\r\nIn #155582, an `enabled` option was added to the `Security` plugin. This\r\noption is not supported or documented. This PR reverts that change.","sha":"4385dc157bccc42cf8a61801db582c41b6e9b297"}}]}] BACKPORT--> Co-authored-by: Jeramy Soucy <[email protected]>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…lastic#175565) ## Summary In elastic#155582, an `enabled` option was added to the `Security` plugin. This option is not supported or documented. This PR reverts that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #155582, an
enabledoption was added to theSecurityplugin. This option is not supported or documented. This PR reverts that change.