Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][EMS] Adding more details about connectivity and link to the stack docs #175551

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Jan 25, 2024

Related to #174716

  • Adds an intro paragraph mentioning the three options regarding EMS and limited connectivity: set up a firewall, disable it fully, or install Elastic Maps Server.
  • Adds a reference to the Elastic Stack air-gapped guide.

@jsanz jsanz added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes docs backport:all-open Backport to all branches that could still receive a release Feature:Maps labels Jan 25, 2024
@jsanz jsanz requested a review from nreese January 25, 2024 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jsanz
Copy link
Member Author

jsanz commented Jan 25, 2024

@nreese are these changes aligned with what you were envisioning? I don't think it is necessary to make any changes outside Kibana docs, but if you see that more content is needed in the Elastic Stack air-gapped guide I'm happy to take a look.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the kibana docs, changes LGTM

I think before we can close #174716, we also need to update https://www.elastic.co/guide/en/elastic-stack/current/air-gapped-install.html#air-gapped-elastic-maps-service with a link to maps-connect-to-ems section and repeat the part about the 3 options 1) disconnect 2) update firewall rules 3) run EMS locally

@jsanz
Copy link
Member Author

jsanz commented Jan 26, 2024

@amyjtechwriter I'm seeing an error in the Docs Preview Links check for this PR. Is it OK to merge this or should I do something about that? Never seen this error coming from a the github action 😓

@nreese I've opened elastic/stack-docs#2658 to point to the full doc and stating the three options there as well.

@bmorelli25
Copy link
Member

updating this branch to pull in #175699. That change should fix the failing doc preview link check.

@jsanz
Copy link
Member Author

jsanz commented Jan 26, 2024

updating this branch to pull in #175699. That change should fix the failing doc preview link check.

@bmorelli25 did it work? I don't see the action running at https://github.com/elastic/kibana/actions/workflows/docs-preview-links.yml but I'll get back to this on Monday. Thanks!

@jsanz jsanz merged commit e69e971 into elastic:main Jan 30, 2024
7 checks passed
@jsanz jsanz deleted the docs/ems/stack-ref branch January 30, 2024 17:34
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 30, 2024
…ack docs (elastic#175551)

Related to elastic#174716

* Adds an intro paragraph mentioning the three options regarding EMS and
limited connectivity: set up a firewall, disable it fully, or install
Elastic Maps Server.
* Adds a reference to the Elastic Stack air-gapped guide.

Co-authored-by: Brandon Morelli <[email protected]>
(cherry picked from commit e69e971)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 175551

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 30, 2024
… the stack docs (#175551) (#175918)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Docs][EMS] Adding more details about connectivity and link to the
stack docs (#175551)](#175551)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jorge
Sanz","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-30T17:34:26Z","message":"[Docs][EMS]
Adding more details about connectivity and link to the stack docs
(#175551)\n\nRelated to #174716\r\n\r\n* Adds an intro paragraph
mentioning the three options regarding EMS and\r\nlimited connectivity:
set up a firewall, disable it fully, or install\r\nElastic Maps
Server.\r\n* Adds a reference to the Elastic Stack air-gapped
guide.\r\n\r\nCo-authored-by: Brandon Morelli
<[email protected]>","sha":"e69e971fb4a8f09b53ea75c61a22882c2f3ac207","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","docs","backport:all-open","Feature:Maps","v8.12.0","v8.13.0"],"title":"[Docs][EMS]
Adding more details about connectivity and link to the stack
docs","number":175551,"url":"https://github.com/elastic/kibana/pull/175551","mergeCommit":{"message":"[Docs][EMS]
Adding more details about connectivity and link to the stack docs
(#175551)\n\nRelated to #174716\r\n\r\n* Adds an intro paragraph
mentioning the three options regarding EMS and\r\nlimited connectivity:
set up a firewall, disable it fully, or install\r\nElastic Maps
Server.\r\n* Adds a reference to the Elastic Stack air-gapped
guide.\r\n\r\nCo-authored-by: Brandon Morelli
<[email protected]>","sha":"e69e971fb4a8f09b53ea75c61a22882c2f3ac207"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175551","number":175551,"mergeCommit":{"message":"[Docs][EMS]
Adding more details about connectivity and link to the stack docs
(#175551)\n\nRelated to #174716\r\n\r\n* Adds an intro paragraph
mentioning the three options regarding EMS and\r\nlimited connectivity:
set up a firewall, disable it fully, or install\r\nElastic Maps
Server.\r\n* Adds a reference to the Elastic Stack air-gapped
guide.\r\n\r\nCo-authored-by: Brandon Morelli
<[email protected]>","sha":"e69e971fb4a8f09b53ea75c61a22882c2f3ac207"}}]}]
BACKPORT-->

Co-authored-by: Jorge Sanz <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
…ack docs (elastic#175551)

Related to elastic#174716

* Adds an intro paragraph mentioning the three options regarding EMS and
limited connectivity: set up a firewall, disable it fully, or install
Elastic Maps Server.
* Adds a reference to the Elastic Stack air-gapped guide.

Co-authored-by: Brandon Morelli <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…ack docs (elastic#175551)

Related to elastic#174716

* Adds an intro paragraph mentioning the three options regarding EMS and
limited connectivity: set up a firewall, disable it fully, or install
Elastic Maps Server.
* Adds a reference to the Elastic Stack air-gapped guide.

Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release docs Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.12.0 v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants