Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12] [Fleet] Fix incorrect count of agents in bulk actions (#175318) #175527

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

Fixes elastic#171914

## Summary
Fix a small issue occurring when there are inactive agents, both regular
and managed.

Another PR with some refactoring for this component will follow.

### Repro steps

- Enroll fleet server on fleet-server-policy - make sure to have two
inactive fleet server agents on this policy as well
- Enroll ~20 agents with horde and make them inactive
- Make fleet server policy "managed"
- Select "inactive" in the status filter
- Click on "Select agents on all pages"
- The bulk actions shouldn't report negative actions. If the count is 0,
the actions will appear disabled

#### Before
![Screenshot 2024-01-22 at 15 59
42](https://github.com/elastic/kibana/assets/16084106/cb8c6c80-b23f-4415-af2a-b4de8ae387f6)

#### After
![Screenshot 2024-01-24 at 15 53
53](https://github.com/elastic/kibana/assets/16084106/6b020016-6171-43d7-bc12-685bf01b7989)

### Checklist

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit f2fb3ee)
@kibanamachine kibanamachine enabled auto-merge (squash) January 25, 2024 11:35
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 25, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +244.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@kibanamachine kibanamachine merged commit b4d153e into elastic:8.12 Jan 25, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants