Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression/im investigate ftr failures #175462

Conversation

vitaliidm
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

vitaliidm and others added 29 commits January 10, 2024 12:07
…/kibana into suppression/im-backend

# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/rule_types/utils/search_after_bulk_create_suppressed_alerts.ts
@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm vitaliidm closed this Jan 25, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 25, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / Detection rule type telemetry @ess @serverless All task telemetry types generically @skipInQA should only have task metric values when no rules are running
  • [job] [logs] FTR Configs #26 / Detection rule type telemetry @ess @serverless All task telemetry types generically @skipInQA should only have task metric values when no rules are running
  • [job] [logs] FTR Configs #55 / Entity Analytics - Risk Engine @ess @serverless Risk Scoring Calculation API with auditbeat data @skipInServerless with asset criticality data "before each" hook for "calculates and persists risk scores with additional criticality metadata and modifiers"
  • [job] [logs] FTR Configs #55 / Entity Analytics - Risk Engine @ess @serverless Risk Scoring Calculation API with auditbeat data @skipInServerless with asset criticality data "before each" hook for "calculates and persists risk scores with additional criticality metadata and modifiers"
  • [job] [logs] FTR Configs #44 / Rule execution logic API Execution logic @ess @serverless EQL type rules with asset criticality should be enriched alert with criticality_level
  • [job] [logs] FTR Configs #44 / Rule execution logic API Execution logic @ess @serverless EQL type rules with asset criticality should be enriched alert with criticality_level

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ruleRegistry 239 241 +2
Unknown metric groups

API count

id before after diff
ruleRegistry 268 270 +2

ESLint disabled in files

id before after diff
securitySolution 72 73 +1

References to deprecated APIs

id before after diff
securitySolution 519 521 +2

Total ESLint disabled count

id before after diff
securitySolution 546 547 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vitaliidm vitaliidm deleted the suppression/im-investigate-ftr-failures branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants