Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] fix(slo): handle invalid stored SLO (#175125) #175442

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[8.12] fix(slo): handle invalid stored SLO (#175125) #175442

merged 1 commit into from
Jan 24, 2024

Conversation

kdelemme
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

@kdelemme
fix(slo): handle invalid stored SLO (elastic#175125)
369e302 
(cherry picked from commit ed41989)

# Conflicts:
#	x-pack/plugins/observability/server/routes/slo/route.ts
#	x-pack/plugins/observability/server/services/slo/slo_repository.ts
@kdelemme kdelemme enabled auto-merge (squash) January 24, 2024 14:56
@kdelemme kdelemme mentioned this pull request Jan 24, 2024
Merged
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / rules_list can filter by last response

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kdelemme kdelemme requested a review from simianhacker January 24, 2024 17:46
@kdelemme kdelemme merged commit 00777da into elastic:8.12 Jan 24, 2024
31 checks passed
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Jan 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme kdelemme deleted the backport/8.12/pr-175125 branch January 24, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
backport Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kdelemme @apmmachine @kibana-ci @elasticmachine @simianhacker