Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] Prevent overwriting managed content #175274

Merged
merged 44 commits into from
Jan 31, 2024

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Jan 22, 2024

Summary

Close #172380

I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization.

To test, import this ndjson file which includes both a managed and an unmanaged visualization:

{"attributes":{"fieldFormatMap":"{\"hour_of_day\":{}}","name":"Kibana Sample Data Logs","runtimeFieldMap":"{\"hour_of_day\":{\"type\":\"long\",\"script\":{\"source\":\"emit(doc['timestamp'].value.getHour());\"}}}","timeFieldName":"timestamp","title":"kibana_sample_data_logs"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-23T19:21:35.919Z","id":"90943e30-9a47-11e8-b64d-95841ca0b247","managed":false,"references":[],"type":"index-pattern","typeMigrationVersion":"8.0.0","updated_at":"2024-01-23T19:21:35.919Z","version":"WzI2LDFd"}
{"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filter\":[]}"},"title":"Managed TSVB Vis","uiStateJSON":"{}","version":1,"visState":"{\"title\":\"Managed TSVB Vis\",\"type\":\"metrics\",\"aggs\":[],\"params\":{\"time_range_mode\":\"entire_time_range\",\"id\":\"acfb97c8-3d01-4471-8bfa-20ad4c081c83\",\"type\":\"timeseries\",\"series\":[{\"time_range_mode\":\"entire_time_range\",\"id\":\"164dbb10-9777-46c6-9a9a-441867f147d9\",\"color\":\"#68BC00\",\"split_mode\":\"everything\",\"palette\":{\"type\":\"palette\",\"name\":\"default\"},\"metrics\":[{\"id\":\"daf0bc80-1651-4582-a57f-909ac5ec4207\",\"type\":\"count\"}],\"separate_axis\":0,\"axis_position\":\"right\",\"formatter\":\"default\",\"chart_type\":\"line\",\"line_width\":1,\"point_size\":1,\"fill\":0.5,\"stacked\":\"none\",\"override_index_pattern\":0,\"series_drop_last_bucket\":0}],\"time_field\":\"\",\"use_kibana_indexes\":true,\"interval\":\"\",\"axis_position\":\"left\",\"axis_formatter\":\"number\",\"axis_scale\":\"normal\",\"show_legend\":1,\"truncate_legend\":1,\"max_lines_legend\":1,\"show_grid\":1,\"tooltip_mode\":\"show_all\",\"drop_last_bucket\":0,\"isModelInvalid\":false,\"index_pattern_ref_name\":\"metrics_0_index_pattern\"}}"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-24T19:55:53.631Z","id":"f0959c7b-f001-4fac-991f-ced2863bd80f","managed":true,"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"metrics_0_index_pattern","type":"index-pattern"}],"type":"visualization","typeMigrationVersion":"8.5.0","updated_at":"2024-01-24T19:55:53.631Z","version":"WzMxLDFd"}
{"excludedObjects":[],"excludedObjectsCount":0,"exportedCount":2,"missingRefCount":0,"missingReferences":[]}

This is how the UI should look for the managed visualization.

Screenshot 2024-01-24 at 12 57 53 PM

Checklist

Delete any items that are not applicable to this PR.

@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon added release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 24, 2024
@drewdaemon
Copy link
Contributor Author

/ci

@elastic elastic deleted a comment from kibana-ci Jan 26, 2024
@drewdaemon drewdaemon marked this pull request as ready for review January 26, 2024 19:59
@drewdaemon drewdaemon requested a review from a team as a code owner January 26, 2024 19:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula added v8.13.0 Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jan 28, 2024
@stratoula
Copy link
Contributor

/ci

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! LGTM!

@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 395 396 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visualizations 808 810 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 270.6KB 271.3KB +712.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 57.4KB 57.4KB +40.0B
Unknown metric groups

API count

id before after diff
visualizations 839 841 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 29d1a0a into elastic:main Jan 31, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 31, 2024
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 1, 2024
* main:
  use build hash in FTR tests
  [Security Solution] Fix moderate typo (elastic#175883)
  [Fleet] Fix conflicting dynamic template mappings for intermediate objects (elastic#175970)
  [Visualize] Prevent overwriting managed content (elastic#175274)
  [SLO] Add/edit form mark optional fields (elastic#175807)
  skip failing test suite (elastic#175984)
  [data views] Provide method of excluding data tiers when getting field list (elastic#167946)
  [Dataset quality] State management (elastic#174906)
  [Cloud Security] add is_internal config option for outputs (elastic#175546)
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Close elastic#172380

I marked this a breaking change since it is preventing users from doing
something they have been able to do before. They can no longer save
changes to managed visualizations. Instead, they have to save changes to
a new visualization.


This is how the UI should look for the managed visualization.

<img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM"
src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — going to
happen in elastic#175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed —
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Close elastic#172380

I marked this a breaking change since it is preventing users from doing
something they have been able to do before. They can no longer save
changes to managed visualizations. Instead, they have to save changes to
a new visualization.


This is how the UI should look for the managed visualization.

<img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM"
src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials — going to
happen in elastic#175150
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed —
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:breaking Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visualize] Prevent overwriting managed content
5 participants