-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize] Prevent overwriting managed content #175274
[Visualize] Prevent overwriting managed content #175274
Conversation
…kibana into lens-respect-managed-content
/ci |
…ct-managed-content
/ci |
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! LGTM!
…ct-managed-content
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…ct-managed-content
…emon/kibana into visualize-respect-managed-content
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* main: use build hash in FTR tests [Security Solution] Fix moderate typo (elastic#175883) [Fleet] Fix conflicting dynamic template mappings for intermediate objects (elastic#175970) [Visualize] Prevent overwriting managed content (elastic#175274) [SLO] Add/edit form mark optional fields (elastic#175807) skip failing test suite (elastic#175984) [data views] Provide method of excluding data tiers when getting field list (elastic#167946) [Dataset quality] State management (elastic#174906) [Cloud Security] add is_internal config option for outputs (elastic#175546)
## Summary Close elastic#172380 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization. This is how the UI should look for the managed visualization. <img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM" src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — going to happen in elastic#175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
## Summary Close elastic#172380 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization. This is how the UI should look for the managed visualization. <img width="970" alt="Screenshot 2024-01-24 at 12 57 53 PM" src="https://github.com/elastic/kibana/assets/315764/7f16d4dd-b03f-4d63-9741-08522f82ac3b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials — going to happen in elastic#175150 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4967 - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
Summary
Close #172380
I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed visualizations. Instead, they have to save changes to a new visualization.
To test, import this
ndjson
file which includes both a managed and an unmanaged visualization:This is how the UI should look for the managed visualization.
Checklist
Delete any items that are not applicable to this PR.