Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detections Response] Rule action filters missing in UI (#175043) #175050

Merged
merged 5 commits into from
Jan 18, 2024
Merged

[Detections Response] Rule action filters missing in UI (#175043) #175050

merged 5 commits into from
Jan 18, 2024

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Jan 17, 2024 •
edited by kibanamachine
Loading

Summary

Addresses #175043

These changes fix the issue where the alerts filter options are not visible on the actions page while creating/editing SIEM rules.

Screenshot 2024-01-17 at 18 43 17

Cause:
These changes https://github.com/elastic/kibana/pull/171049/files#diff-c6d0c14f7d10731840e8e8522e21a1d2ee18a29f120a769db98edf8bd93d9b02R431 where we removed the check of producerId === AlertConsumers.SIEM

@e40pud e40pud added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Detection Engine Security Solution Detection Engine Area labels Jan 17, 2024
@e40pud e40pud requested review from XavierM and yctercero January 17, 2024 16:50
@e40pud e40pud self-assigned this Jan 17, 2024
@e40pud e40pud requested review from a team as code owners January 17, 2024 16:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@yctercero
Copy link
Contributor

Ah! I forgot one last thing. Could you also add the action form file as a dependency for us so that our tests run if that file is changed? The section to add dependencies is here.

@e40pud
Copy link
Contributor Author

e40pud commented Jan 18, 2024

Ah! I forgot one last thing. Could you also add the action form file as a dependency for us so that our tests run if that file is changed? The section to add dependencies is here.

I think we already trigger security solution tests when this file is being modified because of this line:

/^x-pack\/plugins\/triggers_actions_ui\/public\/application\/sections\/action_connector_form/,

since it is a parent folder for this file:

x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_form.tsx

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / Case Owner Selection renders

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.4MB 1.4MB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

@e40pud e40pud merged commit 4b18cdc into elastic:main Jan 18, 2024
41 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 18, 2024
@e40pud
[Detections Response] Rule action filters missing in UI (elastic#175043…
7a7d840 
…) (elastic#175050)

## Summary

Addresses elastic#175043

These changes fix the issue where the alerts filter options are not
visible on the actions page while creating/editing SIEM rules.

<img width="960" alt="Screenshot 2024-01-17 at 18 43 17"
src="https://github.com/elastic/kibana/assets/2700761/81395e6d-f39f-4ccd-bdb6-46a5fdb024ea">

**Cause**:
These changes
https://github.com/elastic/kibana/pull/171049/files#diff-c6d0c14f7d10731840e8e8522e21a1d2ee18a29f120a769db98edf8bd93d9b02R431
where we removed the check of `producerId === AlertConsumers.SIEM`

---------

Co-authored-by: Xavier Mouligneau <[email protected]>
(cherry picked from commit 4b18cdc)
@kibanamachine kibanamachine mentioned this pull request Jan 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 18, 2024
@kibanamachine @e40pud
[8.12] [Detections Response] Rule action filters missing in UI (#175043…
4ec94ee 
…) (#175050) (#175142)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Detections Response] Rule action filters missing in UI (#175043)
(#175050)](#175050)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-18T17:44:08Z","message":"[Detections
Response] Rule action filters missing in UI (#175043) (#175050)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/175043\r\n\r\nThese changes fix
the issue where the alerts filter options are not\r\nvisible on the
actions page while creating/editing SIEM rules.\r\n\r\n<img
width=\"960\" alt=\"Screenshot 2024-01-17 at 18 43
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/81395e6d-f39f-4ccd-bdb6-46a5fdb024ea\">\r\n\r\n**Cause**:\r\nThese
changes\r\nhttps://github.com//pull/171049/files#diff-c6d0c14f7d10731840e8e8522e21a1d2ee18a29f120a769db98edf8bd93d9b02R431\r\nwhere
we removed the check of `producerId ===
AlertConsumers.SIEM`\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier
Mouligneau
<[email protected]>","sha":"4b18cdcc69de6191b1de375ccecee2bac1fb3415","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:
SecuritySolution","backport:prev-minor","Team:Detection
Engine","v8.13.0"],"title":"[Detections Response] Rule action filters
missing in UI
(#175043)","number":175050,"url":"https://github.com/elastic/kibana/pull/175050","mergeCommit":{"message":"[Detections
Response] Rule action filters missing in UI (#175043) (#175050)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/175043\r\n\r\nThese changes fix
the issue where the alerts filter options are not\r\nvisible on the
actions page while creating/editing SIEM rules.\r\n\r\n<img
width=\"960\" alt=\"Screenshot 2024-01-17 at 18 43
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/81395e6d-f39f-4ccd-bdb6-46a5fdb024ea\">\r\n\r\n**Cause**:\r\nThese
changes\r\nhttps://github.com//pull/171049/files#diff-c6d0c14f7d10731840e8e8522e21a1d2ee18a29f120a769db98edf8bd93d9b02R431\r\nwhere
we removed the check of `producerId ===
AlertConsumers.SIEM`\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier
Mouligneau
<[email protected]>","sha":"4b18cdcc69de6191b1de375ccecee2bac1fb3415"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/175050","number":175050,"mergeCommit":{"message":"[Detections
Response] Rule action filters missing in UI (#175043) (#175050)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/175043\r\n\r\nThese changes fix
the issue where the alerts filter options are not\r\nvisible on the
actions page while creating/editing SIEM rules.\r\n\r\n<img
width=\"960\" alt=\"Screenshot 2024-01-17 at 18 43
17\"\r\nsrc=\"https://github.com/elastic/kibana/assets/2700761/81395e6d-f39f-4ccd-bdb6-46a5fdb024ea\">\r\n\r\n**Cause**:\r\nThese
changes\r\nhttps://github.com//pull/171049/files#diff-c6d0c14f7d10731840e8e8522e21a1d2ee18a29f120a769db98edf8bd93d9b02R431\r\nwhere
we removed the check of `producerId ===
AlertConsumers.SIEM`\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier
Mouligneau
<[email protected]>","sha":"4b18cdcc69de6191b1de375ccecee2bac1fb3415"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@e40pud @XavierM @CoenWarmer
[Detections Response] Rule action filters missing in UI (elastic#175043…
0bdac1e 
…) (elastic#175050)

## Summary

Addresses elastic#175043

These changes fix the issue where the alerts filter options are not
visible on the actions page while creating/editing SIEM rules.

<img width="960" alt="Screenshot 2024-01-17 at 18 43 17"
src="https://github.com/elastic/kibana/assets/2700761/81395e6d-f39f-4ccd-bdb6-46a5fdb024ea">

**Cause**:
These changes
https://github.com/elastic/kibana/pull/171049/files#diff-c6d0c14f7d10731840e8e8522e21a1d2ee18a29f120a769db98edf8bd93d9b02R431
where we removed the check of `producerId === AlertConsumers.SIEM`

---------

Co-authored-by: Xavier Mouligneau <[email protected]>
@ASH895-N ASH895-N mentioned this pull request Mar 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

@XavierM XavierM XavierM approved these changes

Assignees

@e40pud e40pud

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:fix Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.1 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@e40pud @elasticmachine @yctercero @kibana-ci @kibanamachine @XavierM