[Security Solution] Create Entity Store index #175025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
siem-ea-8389
branch
from
c3fb8b7 to
bf900ae
Compare
machadoum
force-pushed
the
siem-ea-8389
branch
from
bf900ae to
73ed106
Compare
machadoum
added
Team: SecuritySolution
machadoum
force-pushed
the
siem-ea-8389
branch
from
5836e7f to
c6c9b29
Compare
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
|
@elasticmachine merge upstream |
oatkiller
approved these changes
Jan 22, 2024
|
I think you need a change to the request_context mock: diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/routes/__mocks__/request_context.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/routes/__mocks__/request_context.ts
index cb0b48b8e3f..4f436bfcf2a 100644
--- a/x-pack/plugins/security_solution/server/lib/detection_engine/routes/__mocks__/request_context.ts
+++ b/x-pack/plugins/security_solution/server/lib/detection_engine/routes/__mocks__/request_context.ts
@@ -116,6 +116,7 @@ const createSecuritySolutionRequestContextMock = (
const kibanaRequest = requestMock.create();
return {
+ getEntityStoreDataClient: jest.fn(() => { throw new Error('Not implemented') }),
core,
getServerBasePath: jest.fn(() => ''),
getEndpointAuthz: jest.fn(async () => |
hop-dev
approved these changes
Jan 23, 2024
| logger: this.options.logger, | ||
| options: { | ||
| index: getEntityStoreIndex(this.options.namespace), | ||
| mappings: mappingFromFieldMap(entityStoreFieldMap, 'strict'), |
There was a problem hiding this comment.
I know this is a pattern used in other places, but I'm interested. What is the benefit of the field map instead of just storing as a pure elastic mapping?
I have looked at our used of mappingFromFieldMap and I couldn't see where the field map is used anywhere else?
There was a problem hiding this comment.
I just keep it for consistency. Maybe @nkhristinin or @rylnd can answer this question.
x-pack/plugins/security_solution/server/lib/entity_analytics/entity_store/routes/init.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/entity_analytics/entity_store/routes/init.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @machadoum |
machadoum
merged commit 1a7f155
into
elastic:security/feature/entity-store-poc
36 of 37 checks passed
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Apr 22, 2024
**This PR is going to be merged to the [entity-store-poc](https://github.com/elastic/kibana/tree/security/feature/entity-store-poc) feature branch; it won't impact the main branch.** ## Summary * Create `entity_store/init` route that creates the Entity Store index. * Create FTR tests. ### Out of scope * User fields are out of scope. * API privileges are out of scope. ### How to test it? * Call API ``` KIBANA_URL="http://localhost:5601" USER_PASS="{USER}:{PASSWORD}" curl "$KIBANA_URL/internal/entity_store/init" \ -H 'kbn-xsrf:bleh' \ --user "$USER_PASS"\ -X 'POST' \ -H 'elastic-api-version: 1' ``` * Open the console and check if the index `.entities.entities-default` exists #### Run tests **serverless** `yarn run initialize-server:ea:default entity_store serverless` `yarn run run-tests:ea:default entity_store serverless serverlessEnv` **ess** `yarn run initialize-server:ea:default entity_store ess` `yarn run run-tests:ea:default entity_store ess essEnv` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to be merged to the entity-store-poc feature branch; it won't impact the main branch.
Summary
entity_store/initroute that creates the Entity Store index.Out of scope
How to test it?
.entities.entities-defaultexistsRun tests
serverless
yarn run initialize-server:ea:default entity_store serverlessyarn run run-tests:ea:default entity_store serverless serverlessEnvess
yarn run initialize-server:ea:default entity_store essyarn run run-tests:ea:default entity_store ess essEnvChecklist