Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Skip flaky test #174990

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[Security Solution] Skip flaky test #174990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea288f
Revert unskip flaky test
machadoum Jan 17, 2024
d431408
Merge branch 'main' into siem-ea-174859
machadoum Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/hosts/host_risk_tab.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { hostsUrl } from '../../../urls/navigation';
import { kqlSearch } from '../../../tasks/security_header';
import { mockRiskEngineEnabled } from '../../../tasks/entity_analytics';

// Tracked by https://github.com/elastic/security-team/issues/7696
describe('risk tab', { tags: ['@ess', '@serverless'] }, () => {
describe('with legacy risk score', () => {
before(() => {
Expand All @@ -35,6 +34,11 @@ describe('risk tab', { tags: ['@ess', '@serverless'] }, () => {
// by some reason after navigate to host risk, page is sometimes is reload or go to all host tab
// this fix wait until we fave host in all host table, and then we go to risk tab
cy.contains('siem-kibana');

// Sometimes it doesn't navigate to the risk tab an causes flakiness
// Curiously the "renders the table" test doesn't fail
// https://github.com/elastic/kibana/issues/174860
// https://github.com/elastic/kibana/issues/174859
navigateToHostRiskDetailTab();
});

Expand All @@ -50,15 +54,17 @@ describe('risk tab', { tags: ['@ess', '@serverless'] }, () => {
cy.get(HOST_BY_RISK_TABLE_CELL).eq(7).should('have.text', 'Low');
});

it('filters the table', () => {
// Flaky
it.skip('filters the table', () => {
openRiskTableFilterAndSelectTheCriticalOption();

cy.get(HOST_BY_RISK_TABLE_CELL).eq(3).should('not.have.text', 'siem-kibana');

removeCriticalFilterAndCloseRiskTableFilter();
});

it('should be able to change items count per page', () => {
// Flaky
it.skip('should be able to change items count per page', () => {
selectFiveItemsPerPageOption();

cy.get(HOST_BY_RISK_TABLE_HOSTNAME_CELL).should('have.length', 5);
Expand Down Expand Up @@ -97,7 +103,8 @@ describe('risk tab', { tags: ['@ess', '@serverless'] }, () => {
cy.get(HOST_BY_RISK_TABLE_CELL).eq(7).should('have.text', 'Critical');
});

it('filters the table', () => {
// Flaky
it.skip('filters the table', () => {
openRiskTableFilterAndSelectTheCriticalOption();

cy.get(HOST_BY_RISK_TABLE_CELL).eq(3).should('not.have.text', 'siem-kibana');
Expand All @@ -106,7 +113,7 @@ describe('risk tab', { tags: ['@ess', '@serverless'] }, () => {
});

// Flaky
it('should be able to change items count per page', () => {
it.skip('should be able to change items count per page', () => {
selectFiveItemsPerPageOption();

cy.get(HOST_BY_RISK_TABLE_HOSTNAME_CELL).should('have.length', 5);
Expand Down