Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Loop color mapping in auto-mode #174701

Closed
wants to merge 2 commits into from

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Jan 11, 2024

Summary

This PR brings back the legacy behavior of looping colors when more terms than the available colors are visualized in the chart.

fix #168891

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@markov00 markov00 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens ci:cloud-deploy Create or update a Cloud deployment labels Jan 11, 2024
@markov00
Copy link
Member Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 11, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / AlertPropertyActions does show the property actions with only delete permissions
  • [job] [logs] Jest Tests #2 / AlertPropertyActions remove alerts correctly
  • [job] [logs] Jest Tests #2 / AlertPropertyActions renders the correct number of actions
  • [job] [logs] Jest Tests #2 / AlertPropertyActions renders the modal info correctly for multiple alert
  • [job] [logs] Jest Tests #2 / AlertPropertyActions renders the modal info correctly for one alert
  • [job] [logs] Jest Tests #2 / AssigneesFilterPopover calls onSelectionChange when 1 user is selected
  • [job] [logs] Jest Tests #5 / Color mapping - color generation returns max number of colors defined in palette, use other color otherwise
  • [job] [logs] Jest Tests #5 / Color mapping - color generation returns max number of colors defined in palette, use other color otherwise
  • [job] [logs] Jest Tests #5 / color mapping load a default color mapping
  • [job] [logs] Jest Tests #5 / color mapping load a default color mapping
  • [job] [logs] Jest Tests #2 / FileAttachmentEvent renders clickable name

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPartitionVis 40.8KB 40.9KB +60.0B
expressionTagcloud 23.2KB 23.2KB +60.0B
expressionXY 132.3KB 132.3KB +60.0B
lens 1.4MB 1.4MB +139.0B
total +319.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00
Copy link
Member Author

closing as replaced by #175144

@markov00 markov00 closed this Jan 31, 2024
@markov00 markov00 deleted the 2024_01_11-loop_colors branch January 31, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Add option to color all terms in new color mapping UX
2 participants