-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] feat(plugins-apm): add metrics dashboard for opentelemetry-node services #174700
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…c/kibana into feat-add-otel-host-metrics-memory
@elasticmachine merge upstream |
@david-luna thanks for adding this.
The fix is merged, should we also add the CPU metrics ? |
Thanks @kpatticha for reviewing this :) I'd prefer to merge this and create a new PR to add CPU metrics for 2 reasons:
|
@@ -7,6 +7,7 @@ | |||
|
|||
export const AGENT_NAME_DASHBOARD_FILE_MAPPING: Record<string, string> = { | |||
nodejs: 'nodejs', | |||
'opentelemetry/nodejs': 'opentelemetry-nodejs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I would use opentelemetry_nodejs
(underscore) similar to the filename for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @david-luna . The code LGTM, I couldn't test the UI cause I couldn't find any metrics data on edge-light for opentelemetry-node services.
Unless I miss something the metrics tab seems to be broken for other oTel services (if not all) on edge-lite. FYI, @AlexanderWert are you aware of any work or ticket related to the metrics tab in APM? |
you're right. The problem is that documents received from Open Telemetry agents have different shape and the fields do not match for our default metrics dashboard
this is the issue for reference elastic/apm#806 |
thanks |
…c/kibana into feat-add-otel-host-metrics-memory
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
… services (elastic#174700) This PR adds a specific dashboard for metrics being reported by an opentelemetry nodejs agent. As for now the UI is showing a default dashboard that does not conform to the document structure and therefore not showing the real values of the metrics. The new dashboard contains 2 panels: - memory usage in bytes - memory utilization in %
… services (elastic#174700) This PR adds a specific dashboard for metrics being reported by an opentelemetry nodejs agent. As for now the UI is showing a default dashboard that does not conform to the document structure and therefore not showing the real values of the metrics. The new dashboard contains 2 panels: - memory usage in bytes - memory utilization in %
Summary
This PR add a specific dashboard for metrics being reported by an opentelemetry agent. As for now the UI is showing a default dashboard that does not conform to the document structure and therefore not showing the real values of the metrics.
The current dasshboard
The new dashboard contains 2 panels:
CPU metrics are not added yet since there is a bug in
@opentelemetry/host-metrics
. The fix is pending to be merged open-telemetry/opentelemetry-js-contrib#1785Checklist
N/A
For maintainers