Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix package edit redirect #174531

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jan 9, 2024

Description

Resolve #173805

Redirect to the agent package policy list when editing an integration from that page. This is done the same way we do for the upgrade using a query string parameter from.

How to tests

try to edit an integration from the agent policy details page => save it => you should go back to the agent policy details page.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet
Copy link
Member Author

nchaulet commented Jan 9, 2024

/ci

@nchaulet nchaulet self-assigned this Jan 9, 2024
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jan 9, 2024
@nchaulet nchaulet marked this pull request as ready for review January 9, 2024 18:32
@nchaulet nchaulet requested a review from a team as a code owner January 9, 2024 18:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +173.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 66aa374 into elastic:main Jan 9, 2024
21 checks passed
@nchaulet nchaulet deleted the fix-package-edit-redirect branch January 9, 2024 20:05
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 9, 2024
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 10, 2024
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
@jlind23
Copy link
Contributor

jlind23 commented Jan 15, 2024

@nchaulet can we backport this to 8.12 please?

nchaulet added a commit to nchaulet/kibana that referenced this pull request Jan 15, 2024
@nchaulet
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nchaulet added a commit that referenced this pull request Jan 15, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Fleet] Fix package edit redirect
(#174531)](#174531)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-09T20:05:01Z","message":"[Fleet]
Fix package edit redirect
(#174531)","sha":"66aa37444a16c5d40523b9cae3267983dd20a9db","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Fleet","v8.13.0"],"number":174531,"url":"https://github.com/elastic/kibana/pull/174531","mergeCommit":{"message":"[Fleet]
Fix package edit redirect
(#174531)","sha":"66aa37444a16c5d40523b9cae3267983dd20a9db"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174531","number":174531,"mergeCommit":{"message":"[Fleet]
Fix package edit redirect
(#174531)","sha":"66aa37444a16c5d40523b9cae3267983dd20a9db"}}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <[email protected]>
@mistic mistic added v8.12.1 and removed v8.12.0 labels Jan 17, 2024
@mistic
Copy link
Member

mistic commented Jan 17, 2024

This PR didn't make it into the latest BC for 8.12.0. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: On editing the integration from the Agent Policies tab, user is redirected to Integrations tab.
8 participants