Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Docs] add metric coloring doc #174405

Merged
merged 7 commits into from
Jan 16, 2024

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Jan 5, 2024

Summary

Fix #174379

Adds an FAQ section for the coloring behavior of the metric visualization

Screenshot 2024-01-08 at 12 51 27 PM

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Documentation preview:

@drewdaemon drewdaemon changed the title add metric coloring doc [Lens][Docs] add metric coloring doc Jan 8, 2024
@drewdaemon drewdaemon marked this pull request as ready for review January 8, 2024 19:50
@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens labels Jan 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@drewdaemon
Copy link
Contributor Author

@amyjtechwriter please feel free to suggest corrections for any capitalization / style errors. Also, would be nice to get an understandability check from you. Thanks!

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful :)

I am not sure about the image with the arrow 🤔 Not sure who is the best person to ask from the design perspective.

@MichaelMarcialis do you know maybe?

Copy link
Contributor

@amyjtechwriter amyjtechwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've left a few small suggestions. In terms of sense checking, the logic explanation makes sense to me so I hope our users agree! :)

docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon
Copy link
Contributor Author

@MichaelMarcialis I'm going to merge this, but feel free to chime in after the fact.

@drewdaemon drewdaemon merged commit babd0ee into elastic:main Jan 16, 2024
6 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 16, 2024
@MichaelMarcialis
Copy link
Contributor

I am not sure about the image with the arrow 🤔 Not sure who is the best person to ask from the design perspective.

@MichaelMarcialis do you know maybe?

Apologies for the delayed response. I'm uncertain if there is an existing designer(s) that is dedicated to the Elastic docs or what the current rules are for highlighting specific areas of an image. I imagine @KOTungseth may know the answer to both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens][Docs] Explain how coloring works in the metric visualization
7 participants