Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Unskip alerts response console test #174341

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Jan 5, 2024

Summary

Re-enable response console tests for Alerts page.

closes /issues/169689
closes /issues/173472

Flaky test runner

Checklist

@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.12.0 v8.13.0 labels Jan 5, 2024
@ashokaditya ashokaditya self-assigned this Jan 5, 2024
@ashokaditya ashokaditya requested a review from a team as a code owner January 5, 2024 11:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@@ -73,7 +73,7 @@ export const getCypressBaseConfig = (
// baseUrl: To override, set Env. variable `CYPRESS_BASE_URL`
baseUrl: 'http://localhost:5601',
supportFile: 'public/management/cypress/support/e2e.ts',
specPattern: 'public/management/cypress/e2e/**/*.cy.{js,jsx,ts,tsx}',
specPattern: 'public/management/cypress/e2e/**/alerts_response_console.cy.{js,jsx,ts,tsx}',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo before merge

@ashokaditya ashokaditya changed the title [Security Solution][Endpoint] unskip alerts response console test [Security Solution][Endpoint] Unskip alerts response console test Jan 5, 2024
@ashokaditya ashokaditya force-pushed the task/dw-unskip-alerts-response-console-test branch from 82cdae9 to 8c8997a Compare January 5, 2024 13:46
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: you did NOT actually change anything in this PR other than to remove the .skip() correct?

looks like maybe the code was just moved around

@ashokaditya
Copy link
Member Author

Just to confirm: you did NOT actually change anything in this PR other than to remove the .skip() correct?

looks like maybe the code was just moved around
@paul-tavares

Correct. I just moved some of the test setup and teardown into a single block, as I noticed that the two tickets have failures in either test setup or teardown. Also is easier to maintain and read.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@ashokaditya ashokaditya merged commit 595e69e into elastic:main Jan 5, 2024
38 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 5, 2024
@ashokaditya ashokaditya deleted the task/dw-unskip-alerts-response-console-test branch January 5, 2024 14:53
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
…astic#174341)

## Summary

Re-enable response console tests for Alerts page.

closes elastic/issues/169689
closes elastic/issues/173472

### Flaky test runner
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4766
x 100 (all pass)

### Checklist

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment