-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Endpoint] Unskip alerts response console test #174341
[Security Solution][Endpoint] Unskip alerts response console test #174341
Conversation
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
@@ -73,7 +73,7 @@ export const getCypressBaseConfig = ( | |||
// baseUrl: To override, set Env. variable `CYPRESS_BASE_URL` | |||
baseUrl: 'http://localhost:5601', | |||
supportFile: 'public/management/cypress/support/e2e.ts', | |||
specPattern: 'public/management/cypress/e2e/**/*.cy.{js,jsx,ts,tsx}', | |||
specPattern: 'public/management/cypress/e2e/**/alerts_response_console.cy.{js,jsx,ts,tsx}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo before merge
closes elastic/issues/169689 closes elastic/issues/173472
82cdae9
to
8c8997a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: you did NOT actually change anything in this PR other than to remove the .skip()
correct?
looks like maybe the code was just moved around
Correct. I just moved some of the test setup and teardown into a single block, as I noticed that the two tickets have failures in either test setup or teardown. Also is easier to maintain and read. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @ashokaditya |
…astic#174341) ## Summary Re-enable response console tests for Alerts page. closes elastic/issues/169689 closes elastic/issues/173472 ### Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4766 x 100 (all pass) ### Checklist - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed
Summary
Re-enable response console tests for Alerts page.
closes /issues/169689
closes /issues/173472
Flaky test runner
Checklist