Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Use the shared ux Markdown component #174320

Merged
merged 12 commits into from
Feb 12, 2024
Merged

[ES|QL] Use the shared ux Markdown component #174320

merged 12 commits into from
Feb 12, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 5, 2024 •
edited
Loading

Summary

Part of #174290
Part of #173495

This PR:

  • uses the shared ux markdown component for ES|QL reference
  • this comes with a nice addition, the code block has a copy button
  • removes the sql documentation file, I plan to remove all the SQL related code in 8.14. As this transition to the new markdown needs some manual work I didn't want to do it for SQL as we removed it from the UI and we are going to remove it soonish from the code too
image

@stratoula
Copy link
Contributor Author

Blocked by #176246

I found out some latency in the new markdown utility. The shared ux fixed it on the eui and the fix will be merged in kibana with the aforementioned PR

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula marked this pull request as ready for review February 9, 2024 12:40
@stratoula stratoula requested a review from a team as a code owner February 9, 2024 12:40
@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Feb 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana v8.13.0 labels Feb 9, 2024
@stratoula
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #75 / serverless security UI navigation "before all" hook for "has security serverless side nav"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1263 1264 +1
securitySolution 4960 4961 +1
stackAlerts 135 136 +1
textBasedLanguages 53 54 +1
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +14.0B
textBasedLanguages 162.4KB 135.4KB -26.9KB
total -26.9KB
Unknown metric groups

async chunk count

id before after diff
textBasedLanguages 3 2 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula stratoula merged commit 226b3f3 into elastic:main Feb 12, 2024
19 checks passed
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@stratoula @kibanamachine @CoenWarmer
[ES|QL] Use the shared ux Markdown component (elastic#174320)
9d098a7 
## Summary

Part of elastic#174290
Part of elastic#173495

This PR:

- uses the shared ux markdown component for ES|QL reference
- this comes with a nice addition, the code block has a copy button
- removes the sql documentation file, I plan to remove all the SQL
related code in 8.14. As this transition to the new markdown needs some
manual work I didn't want to do it for SQL as we removed it from the UI
and we are going to remove it soonish from the code too

<img width="1031" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/038c6ba6-143c-41d9-8186-3e91a2fb4c1d">

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@stratoula @kibanamachine @fkanout
[ES|QL] Use the shared ux Markdown component (elastic#174320)
16c3a12 
## Summary

Part of elastic#174290
Part of elastic#173495

This PR:

- uses the shared ux markdown component for ES|QL reference
- this comes with a nice addition, the code block has a copy button
- removes the sql documentation file, I plan to remove all the SQL
related code in 8.14. As this transition to the new markdown needs some
manual work I didn't want to do it for SQL as we removed it from the UI
and we are going to remove it soonish from the code too

<img width="1031" alt="image"
src="https://github.com/elastic/kibana/assets/17003240/038c6ba6-143c-41d9-8186-3e91a2fb4c1d">

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stratoula @elasticmachine @kibana-ci @ppisljar @kibanamachine