[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab #174242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
neptunian
approved these changes
Jan 4, 2024
| export const NewBadge = () => ( | ||
| <EuiBadge color="accent"> | ||
| {i18n.translate('xpack.infra.newBadgeLabel', { | ||
| defaultMessage: 'NEW', |
There was a problem hiding this comment.
Do we really need to Uppercase it?
There was a problem hiding this comment.
I am not sure that I am the right person to decide that - I saw the profiling badge and the nav menu badge are uppercase so I tried to keep it consistent then I checked that in APM it's not 😕 So IMO if we have the same look everywhere is better but which one is better from the UX perspective (uppercase or lowercase) and how much we want to put the attention there I don't know. I would keep it like that here but we can also open a discussion with the design team and add an issue to align the labels everywhere, wdyt?
jennypavlova
deleted the
173156-obsux-profiling-infra-add-new-badge-to-the-profiling-tab
branch
mykolaharmash
added
v8.12.0
and removed
backport:skip
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Jan 16, 2024
…#174242) Closes elastic#173156 ## Summary This PR adds a `NEW` badge to the profiling tab and changes the profiling prompt badge color to pink ## Testing The badges can be checked on the node details page and inside the host details flyout:   (cherry picked from commit 1182ce6)
mykolaharmash
added a commit
that referenced
this pull request
Jan 16, 2024
…174242) (#174880) # Backport This will backport the following commits from `main` to `8.12`: - [[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (#174242)](#174242) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-04T16:09:09Z","message":"[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (#174242)\n\nCloses #173156 \r\n\r\n## Summary\r\n\r\nThis PR adds a `NEW` badge to the profiling tab and changes the\r\nprofiling prompt badge color to pink\r\n\r\n## Testing\r\nThe badges can be checked on the node details page and inside the host\r\ndetails flyout:\r\n\r\n\r\n\r\n","sha":"1182ce678c3b190aa5172f2b473db0d84ba12f5d","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","Team:obs-ux-infra_services","v8.13.0"],"number":174242,"url":"https://github.com/elastic/kibana/pull/174242","mergeCommit":{"message":"[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (#174242)\n\nCloses #173156 \r\n\r\n## Summary\r\n\r\nThis PR adds a `NEW` badge to the profiling tab and changes the\r\nprofiling prompt badge color to pink\r\n\r\n## Testing\r\nThe badges can be checked on the node details page and inside the host\r\ndetails flyout:\r\n\r\n\r\n\r\n","sha":"1182ce678c3b190aa5172f2b473db0d84ba12f5d"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174242","number":174242,"mergeCommit":{"message":"[ObsUX][Profiling, Infra] Add NEW badge to the Profiling tab (#174242)\n\nCloses #173156 \r\n\r\n## Summary\r\n\r\nThis PR adds a `NEW` badge to the profiling tab and changes the\r\nprofiling prompt badge color to pink\r\n\r\n## Testing\r\nThe badges can be checked on the node details page and inside the host\r\ndetails flyout:\r\n\r\n\r\n\r\n","sha":"1182ce678c3b190aa5172f2b473db0d84ba12f5d"}}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
|
This PR didn't make it into the latest BC for 8.12.0. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173156
Summary
This PR adds a
NEWbadge to the profiling tab and changes the profiling prompt badge color to pinkTesting
The badges can be checked on the node details page and inside the host details flyout:
