Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add xpack.fleet.isAirGapped flag #174214

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Jan 3, 2024

Summary

Closes #173125

Adds a new xpack.fleet.isAirGapped flag to kibana.yml that allow users in air-gapped environments to inform Fleet that it should "fail fast" and skip unnecessary requests that won't be possible as Kibana doesn't have internet access.

This PR also uses the new flag to skip the API request to the product_versions API if the airgapped flag is set to true. There are probably other places we could use this flag in a similar way, but they can be handled separately from this PR.

Checklist

Delete any items that are not applicable to this PR.

@kpollich kpollich added release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0 labels Jan 3, 2024
@kpollich kpollich self-assigned this Jan 3, 2024
@kpollich kpollich requested a review from a team as a code owner January 3, 2024 19:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 7a613fb into elastic:main Jan 4, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Add Agent enrolment panel hangs when Kibana can't access www.elastic.co
6 participants